[SPARK] Add in config value needed in tests once Spark 3.2 is supported #3090
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The (non-Iceberg) tables generated during testing in
TestAddFiles
procedure are partitioned on date columns that are not casts to strings.Most metastores will handle this just fine, but Derby and some others will throw an exception. MySQL and Postgres backed metastores will handle this fine and won't need to fall back or generate an exception.
Without setting this, many of the tests in
TestAddFiles
fail withMetaException(message:Filtering is supported only on partition keys of type string)
This is related to https://issues.apache.org/jira/browse/SPARK-36128. The consensus in the community was that
false
is the best value for this in production environments as this can in theory have impact on performance, to let users know and adjust their data accordingly.For tests though, it should probably be set everywhere.
Setting it here now as this is the only place that I've encountered that will need it once https://issues.apache.org/jira/browse/SPARK-36128 is part of a supported version (should be Spark 3.2 which has release candidates though is not GA).