-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new SnowflakeCatalog implementation to enable directly using Snowflake-managed Iceberg tables #6428
Add new SnowflakeCatalog implementation to enable directly using Snowflake-managed Iceberg tables #6428
Commits on Dec 13, 2022
-
Initial read-only Snowflake Catalog implementation by @sfc-gh-mparmar (…
…#1) Initial read-only Snowflake Catalog implementation built on top of the Snowflake JDBC driver, providing support for basic listing of namespaces, listing of tables, and loading/reads of tables. Auth options are passthrough to the JDBC driver. Co-authored-by: Maninder Parmar <maninder.parmar@snowflake.com> Co-authored-by: Maninder Parmar <maninder.parmar+oss@snowflake.com> Co-authored-by: Dennis Huo <dennis.huo+oss@snowflake.com>
Configuration menu - View commit details
-
Copy full SHA for 5ad32b0 - Browse repository at this point
Copy the full SHA 5ad32b0View commit details
Commits on Dec 14, 2022
-
Add JdbcSnowflakeClientTest using mocks (#2)
Add JdbcSnowflakeClientTest using mocks; provides full coverage of JdbcSnowflakeClient and entities' ResultSetHandler logic. Also update target Spark runtime versions to be included.
Configuration menu - View commit details
-
Copy full SHA for 930a3f0 - Browse repository at this point
Copy the full SHA 930a3f0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 86b3d11 - Browse repository at this point
Copy the full SHA 86b3d11View commit details
Commits on Dec 16, 2022
-
Add test { useJUnitPlatform() } tuple to iceberg-snowflake for
consistency and future interoperability with inheriting from abstact unittest base classes.
Configuration menu - View commit details
-
Copy full SHA for 076a14a - Browse repository at this point
Copy the full SHA 076a14aView commit details
Commits on Dec 17, 2022
-
Configuration menu - View commit details
-
Copy full SHA for a7b5aa7 - Browse repository at this point
Copy the full SHA a7b5aa7View commit details -
Misc test-related refactors per review suggestions
-Convert unittests to all use assertj/Assertions for "fluent assertions" -Refactor test injection into overloaded initialize() method -Add test cases for close() propagation -Use CloseableGroup.
Configuration menu - View commit details
-
Copy full SHA for dd5255c - Browse repository at this point
Copy the full SHA dd5255cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 500b36b - Browse repository at this point
Copy the full SHA 500b36bView commit details -
Move TableIdentifier checks out of newTableOps into the
SnowflakTableOperations class itself, add test case.
Configuration menu - View commit details
-
Copy full SHA for ad2c55f - Browse repository at this point
Copy the full SHA ad2c55fView commit details -
Refactor out any Namespace-related business logic from the lower
SnowflakeClient/JdbcSnowflakeClient layers and merge SnowflakeTable and SnowflakeSchema into a single SnowflakeIdentifier that also encompasses ROOT and DATABASE level identifiers. A SnowflakeIdentifier thus functions like a type-checked/constrained Iceberg TableIdentifier, and eliminates any tight coupling between a SnowflakeClient and Catalog business logic. Parsing of Namespace numerical levels into a SnowflakeIdentifier is now fully encapsulated in NamespaceHelpers so that callsites don't duplicate namespace-handling/validation logic.
Configuration menu - View commit details
-
Copy full SHA for 7f13674 - Browse repository at this point
Copy the full SHA 7f13674View commit details -
Finish migrating JdbcSnowflakeClientTest off any usage of org.junit.A…
…ssert in favor of assertj's Assertions.
Configuration menu - View commit details
-
Copy full SHA for 58d258e - Browse repository at this point
Copy the full SHA 58d258eView commit details
Commits on Dec 20, 2022
-
Style refactorings from review comments, expanded and moved InMemoryF…
…ileIO into core with its own unittest.
Configuration menu - View commit details
-
Copy full SHA for 0183129 - Browse repository at this point
Copy the full SHA 0183129View commit details
Commits on Dec 21, 2022
-
Fix behavior of getNamespaceMetadata to throw when the namespace doesn't
exist. Refactor for naming conventions and consolidating identifier handling into NamespaceHandlers. Make FileIO instantiated fresh for each newTableOps call.
Configuration menu - View commit details
-
Copy full SHA for ca6deab - Browse repository at this point
Copy the full SHA ca6deabView commit details -
Configuration menu - View commit details
-
Copy full SHA for b3a2842 - Browse repository at this point
Copy the full SHA b3a2842View commit details -
Define minimal ResultSetParser/QueryHarness classes to fully replace
any use of commons-dbutils; refactor ResultSet handling fully into JdbcSnowflakeClient.java.
Configuration menu - View commit details
-
Copy full SHA for 676d024 - Browse repository at this point
Copy the full SHA 676d024View commit details
Commits on Dec 23, 2022
-
Update snowflake/src/main/java/org/apache/iceberg/snowflake/Snowflake…
…TableOperations.java Co-authored-by: Eduard Tudenhöfner <etudenhoefner@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for cc493d0 - Browse repository at this point
Copy the full SHA cc493d0View commit details -
Refactor style suggestions; remove debug-level logging, arguments in …
…exceptions, private members if not accessed outside, move precondition checks, add test for NamespaceHelpers.
Configuration menu - View commit details
-
Copy full SHA for ce7e28c - Browse repository at this point
Copy the full SHA ce7e28cView commit details
Commits on Jan 6, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 2729e64 - Browse repository at this point
Copy the full SHA 2729e64View commit details
Commits on Jan 7, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 4c1e79f - Browse repository at this point
Copy the full SHA 4c1e79fView commit details -
Configuration menu - View commit details
-
Copy full SHA for bc0c6ee - Browse repository at this point
Copy the full SHA bc0c6eeView commit details
Commits on Jan 9, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 8240d9e - Browse repository at this point
Copy the full SHA 8240d9eView commit details
Commits on Jan 10, 2023
-
Configuration menu - View commit details
-
Copy full SHA for ebe5dd6 - Browse repository at this point
Copy the full SHA ebe5dd6View commit details
Commits on Jan 13, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 9e9b9e6 - Browse repository at this point
Copy the full SHA 9e9b9e6View commit details
Commits on Jan 14, 2023
-
Configuration menu - View commit details
-
Copy full SHA for e8fee31 - Browse repository at this point
Copy the full SHA e8fee31View commit details