Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nessie: Remove compile-time Hadoop dependency #7054

Merged
merged 1 commit into from
Mar 14, 2023
Merged

Nessie: Remove compile-time Hadoop dependency #7054

merged 1 commit into from
Mar 14, 2023

Conversation

nastra
Copy link
Contributor

@nastra nastra commented Mar 9, 2023 •
edited

This fixes the same issue as #7049 by removing the compile-time dependency on Hadoop's Configuration.

@github-actions github-actions bot added the NESSIE label Mar 9, 2023
@nastra
Copy link
Contributor Author

nastra commented Mar 9, 2023

/cc @snazy @ajantha-bhat @dimas-b

snazy
snazy approved these changes Mar 9, 2023
View reviewed changes
Copy link
Member

@snazy snazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 on removing that dependency just for the sake of hadoop config!
It's a pain to have that hadoop deps.

dimas-b
dimas-b approved these changes Mar 13, 2023
View reviewed changes
Copy link
Contributor

@dimas-b dimas-b left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 Hadoop deps is a pain, indeed

@nastra nastra requested a review from Fokko March 14, 2023 07:23
Fokko
Fokko approved these changes Mar 14, 2023
View reviewed changes
Copy link
Contributor

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! And removing Hadoop makes a lot of sense to me

@Fokko Fokko merged commit f5131af into apache:master Mar 14, 2023
@nastra nastra deleted the remove-hadoop-compile-dep branch March 14, 2023 09:36
krvikash pushed a commit to krvikash/iceberg that referenced this pull request Mar 16, 2023
@nastra @krvikash
Nessie: Remove compile-time Hadoop dependency (apache#7054)
e730bca
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snazy snazy snazy approved these changes

@Fokko Fokko Fokko approved these changes

@ajantha-bhat ajantha-bhat ajantha-bhat approved these changes

@dimas-b dimas-b dimas-b approved these changes

Assignees
No one assigned
Labels
NESSIE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@nastra @snazy @Fokko @ajantha-bhat @dimas-b