Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flink: backport PR #7978. switch to FileScanTaskParser for JSON serialization of IcebergSourceSplit #8228

Merged
merged 1 commit into from
Aug 10, 2023
Merged

Flink: backport PR #7978. switch to FileScanTaskParser for JSON serialization of IcebergSourceSplit #8228

merged 1 commit into from
Aug 10, 2023

Conversation

stevenzwu
Copy link
Contributor

it is a clean back port.

confirmed git diff

➜  iceberg git:(backport-7978) ✗ git diff --no-index  flink/v1.15/flink/src/main/java/org/apache/iceberg/flink/source  flink/v1.17/flink/src/main/java/org/apache/iceberg/flink/source
➜  iceberg git:(backport-7978) ✗ git diff --no-index  flink/v1.16/flink/src/main/java/org/apache/iceberg/flink/source  flink/v1.17/flink/src/main/java/org/apache/iceberg/flink/source

test folder has some diff related to assertj change, not related to this change

➜  iceberg git:(backport-7978) ✗ git diff --no-index  flink/v1.15/flink/src/test/java/org/apache/iceberg/flink/source  flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/source
➜  iceberg git:(backport-7978) ✗ git diff --no-index  flink/v1.16/flink/src/test/java/org/apache/iceberg/flink/source  flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/source

@stevenzwu stevenzwu requested a review from pvary August 4, 2023 18:01
@github-actions github-actions bot added the flink label Aug 4, 2023
ConeyLiu
ConeyLiu approved these changes Aug 10, 2023
View reviewed changes
Copy link
Contributor

@ConeyLiu ConeyLiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for backport

@stevenzwu stevenzwu merged commit b033de7 into apache:master Aug 10, 2023
13 checks passed
@stevenzwu
Copy link
Contributor Author

thanks @pvary and @ConeyLiu for reviews

@stevenzwu stevenzwu mentioned this pull request Sep 27, 2023
Merged
@stevenzwu stevenzwu mentioned this pull request Jan 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ConeyLiu ConeyLiu ConeyLiu approved these changes

@pvary pvary pvary approved these changes

Assignees
No one assigned
Labels
flink
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@stevenzwu @ConeyLiu @pvary