Backporting Flink: Watermark Read Options to 1.17 and 1.16 #9456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodmeneses
force-pushed
the
backPorting
branch
from
02d9bc9
to
6274a57
Compare
mas-chen
approved these changes
Jan 11, 2024
|
@rodmeneses I assume you have checked the diff that nothing is related to this change, e.g. #8228 |
stevenzwu
approved these changes
Jan 11, 2024
|
Thanks @rodmeneses for the backport, and @stevenzwu for the review! |
geruh
pushed a commit
to geruh/iceberg
that referenced
this pull request
Jan 26, 2024
adnanhemani
pushed a commit
to adnanhemani/iceberg
that referenced
this pull request
Jan 30, 2024
devangjhabakh
pushed a commit
to cdouglas/iceberg
that referenced
this pull request
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flink: Backports the Watermark Read Options to 1.17 and 1.16
The patch was cleanly applied to both 1.17 and 1.16
source:
git diff --no-index flink/v1.16/flink/src/main/java/org/apache/iceberg/flink/source flink/v1.18/flink/src/main/java/org/apache/iceberg/flink/sourcebrings some changes unrelated to this PR
git diff --no-index flink/v1.17/flink/src/main/java/org/apache/iceberg/flink/source flink/v1.18/flink/src/main/java/org/apache/iceberg/flink/sourcecame out clean
test:
git diff --no-index flink/v1.16/flink/src/test/java/org/apache/iceberg/flink/source flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/sourcebrings some changes on unrelated to this PR
git diff --no-index flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/source flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/sourcebrings changes, some of them specifically related to junit Version