Spark 3.5: Migrate tests to JUnit5 in actions directory #9367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nastra
reviewed
Dec 23, 2023
...3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestDeleteReachableFilesAction.java
Outdated
Show resolved
Hide resolved
...3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestDeleteReachableFilesAction.java
Outdated
Show resolved
Hide resolved
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestExpireSnapshotsAction.java
Outdated
Show resolved
Hide resolved
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestExpireSnapshotsAction.java
Outdated
Show resolved
Hide resolved
|
@chinmay-bhat can you also please include |
nastra
reviewed
Dec 23, 2023
...k/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestRemoveOrphanFilesAction.java
Outdated
Show resolved
Hide resolved
nastra
reviewed
Dec 23, 2023
...k/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestRemoveOrphanFilesAction.java
Outdated
Show resolved
Hide resolved
nastra
reviewed
Dec 23, 2023
...ark/src/test/java/org/apache/iceberg/spark/actions/TestRewritePositionDeleteFilesAction.java
Show resolved
Hide resolved
nastra
reviewed
Dec 23, 2023
...ark/src/test/java/org/apache/iceberg/spark/actions/TestRewritePositionDeleteFilesAction.java
Outdated
Show resolved
Hide resolved
|
adding |
|
I'll hold off on reviewing this PR once #9368 is in. @chinmay-bhat in the meantime you might want to rebase this PR on top of the commit from #9368 to align the tests |
chinmay-bhat
force-pushed
the
spark-junit5-actions-directory
branch
from
0ab7381
to
63ca1ad
Compare
|
rebased on top of #9368 |
chinmay-bhat
commented
Dec 23, 2023
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestCreateActions.java
Outdated
Show resolved
Hide resolved
|
@chinmay-bhat can you please rebase against latest main? |
…ss and we need both to run
chinmay-bhat
force-pushed
the
spark-junit5-actions-directory
branch
from
ca170c0
to
5ab4769
Compare
|
rebased |
nastra
reviewed
Dec 26, 2023
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestCreateActions.java
Outdated
Show resolved
Hide resolved
nastra
reviewed
Dec 26, 2023
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestCreateActions.java
Show resolved
Hide resolved
nastra
approved these changes
Dec 26, 2023
lisirrx
pushed a commit
to lisirrx/iceberg
that referenced
this pull request
Jan 4, 2024
geruh
pushed a commit
to geruh/iceberg
that referenced
this pull request
Jan 26, 2024
devangjhabakh
pushed a commit
to cdouglas/iceberg
that referenced
this pull request
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the tests in spark/actions directory, now migrated to JUnit5.
Related to PR : #9341
Issue: #9086