Spark 3.5: Remove constructor from parameterized base class #9368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parameterized base classes should not have a constructor but rather have their parameters set via `@Parameter`. All other setup code should go into a `@BeforeEach` method to properly initialize the test environment
nastra
commented
Dec 23, 2023
| @@ -30,7 +29,7 @@ public abstract class CatalogTestBase extends TestBaseWithCatalog { | |||
|
|
|||
| // these parameters are broken out to avoid changes that need to modify lots of test suites | |||
| @Parameters(name = "catalogName = {0}, implementation = {1}, config = {2}") | |||
| public static Object[][] parameters() { | |||
| protected static Object[][] parameters() { | |||
There was a problem hiding this comment.
JUnit4 required this to be public but for JUnit5 we can make it protected
nastra
commented
Dec 23, 2023
| protected static Object[][] parameters() { | ||
| return new Object[][] { | ||
| { | ||
| SparkCatalogConfig.HADOOP.catalogName(), |
There was a problem hiding this comment.
all of the subclasses of this test that didn't specify any particular parameter were running with this configuration (this is also the configuration that was initialized in the default constructors in L70
nastra
commented
Dec 23, 2023
| @@ -50,7 +50,7 @@ public void removeTables() { | |||
| sql("DROP TABLE IF EXISTS %s", tableName); | |||
| } | |||
|
|
|||
| @Test | |||
| @TestTemplate | |||
There was a problem hiding this comment.
all of the subclasses of TestBaseWithCatalog are parameterized tests
nastra
commented
Dec 23, 2023
| @@ -39,11 +38,6 @@ | |||
|
|
|||
| public class TestSparkStagedScan extends CatalogTestBase { | |||
|
|
|||
| public TestSparkStagedScan( | |||
There was a problem hiding this comment.
this and the class below were running with the three different catalog configurations defined in CatalogTestBase and I've verified that this is still the case
lisirrx
pushed a commit
to lisirrx/iceberg
that referenced
this pull request
Jan 4, 2024
geruh
pushed a commit
to geruh/iceberg
that referenced
this pull request
Jan 26, 2024
devangjhabakh
pushed a commit
to cdouglas/iceberg
that referenced
this pull request
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After reviewing/merging #9342 I realized that parameterized base classes should not have a constructor but rather have their parameters set via
@Parameter. All other setup code should go into a@BeforeEachmethod to properly initialize the test environment