Nessie: Infer default API version from URI #9459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimas-b
approved these changes
Jan 11, 2024
nessie/src/main/java/org/apache/iceberg/nessie/NessieCatalog.java
Outdated
Show resolved
Hide resolved
| throw new IllegalArgumentException( | ||
| String.format( | ||
| "URI doesn't end with the version: %s. " | ||
| + "Please configure `client-api-version` in the catalog properties explicitly.", |
There was a problem hiding this comment.
I wonder whether we can just assume v2 in this case... but I'm fine with throwing an exception too.
There was a problem hiding this comment.
If the uri is not ending versions, then it can be a custom implementation which can be based on v1 or v2. So, I didn't want to assume the version there.
dimas-b
approved these changes
Jan 12, 2024
nastra
reviewed
Jan 13, 2024
ajantha-bhat
commented
Jan 16, 2024
| temp.toUri().toString(), | ||
| "client-api-version", | ||
| apiVersion == NessieApiVersion.V2 ? "2" : "1"); | ||
| temp.toUri().toString()); |
There was a problem hiding this comment.
Infers API version using URI.
done. |
nastra
approved these changes
Jan 16, 2024
geruh
pushed a commit
to geruh/iceberg
that referenced
this pull request
Jan 26, 2024
adnanhemani
pushed a commit
to adnanhemani/iceberg
that referenced
this pull request
Jan 30, 2024
devangjhabakh
pushed a commit
to cdouglas/iceberg
that referenced
this pull request
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently default version is v1.
So, If users need V2, they need to configure v2 URI and set the
client-api-versionto "2".With this change, just configuring v2 URI is enough and default version will be inferred from URI.
client-api-versioncan still be used for some special cases where custom URI doesn't end with version number.