-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build: Fix errorprone warning #9531
Conversation
ajantha-bhat
commented
Jan 21, 2024
@@ -105,6 +105,7 @@ subprojects { | |||
'-Xep:IntLongMath:ERROR', | |||
'-Xep:MissingSummary:ERROR', | |||
'-Xep:AnnotateFormatMethod:ERROR', | |||
'-Xep:CollectionUndefinedEquality:ERROR', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Enforced this check. So, new usage will report error for compile and the one who adds the code can check and suppress in the same PR.
@@ -151,6 +151,7 @@ public PositionDeleteIndex loadPositionDeletes( | |||
return PositionDeleteIndexUtil.merge(deletes); | |||
} | |||
|
|||
@SuppressWarnings("CollectionUndefinedEquality") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CharSequenceMap
uses CharSequenceWrapper
for consistent
hashing and equals behaviour . The tool cannot figure out that.
Retriggered the build. |