-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flink: Adds the ability to read from a branch on the Flink Iceberg Source #9547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3385b3f
to
f296155
Compare
stevenzwu
reviewed
Jan 23, 2024
flink/v1.18/flink/src/main/java/org/apache/iceberg/flink/source/StreamingMonitorFunction.java
Show resolved
Hide resolved
4c2b1d2
to
35d6dfb
Compare
pvary
approved these changes
Jan 26, 2024
stevenzwu
reviewed
Jan 27, 2024
...k/v1.18/flink/src/test/java/org/apache/iceberg/flink/source/TestIcebergSourceContinuous.java
Outdated
Show resolved
Hide resolved
flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/source/TestStreamScanSql.java
Outdated
Show resolved
Hide resolved
flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/source/TestStreamScanSql.java
Outdated
Show resolved
Hide resolved
flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/source/TestStreamScanSql.java
Outdated
Show resolved
Hide resolved
flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/source/TestStreamScanSql.java
Outdated
Show resolved
Hide resolved
flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/source/TestStreamScanSql.java
Outdated
Show resolved
Hide resolved
flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/source/TestStreamScanSql.java
Outdated
Show resolved
Hide resolved
35d6dfb
to
346be30
Compare
stevenzwu
reviewed
Jan 29, 2024
flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/source/TestStreamScanSql.java
Outdated
Show resolved
Hide resolved
346be30
to
76c9ad7
Compare
stevenzwu
approved these changes
Jan 30, 2024
Thanks so much for the review @stevenzwu and @pvary |
rodmeneses
added a commit
to rodmeneses/iceberg
that referenced
this pull request
Feb 2, 2024
…read from a branch on the Flink Iceberg Source
rodmeneses
added a commit
to rodmeneses/iceberg
that referenced
this pull request
Feb 2, 2024
…read from a branch on the Flink Iceberg Source
rodmeneses
added a commit
to rodmeneses/iceberg
that referenced
this pull request
Feb 2, 2024
…read from a branch on the Flink Iceberg Source
pvary
pushed a commit
that referenced
this pull request
Feb 5, 2024
…rom a branch on the Flink Iceberg Source (#9627)
rodmeneses
added a commit
to rodmeneses/iceberg
that referenced
this pull request
Feb 19, 2024
devangjhabakh
pushed a commit
to cdouglas/iceberg
that referenced
this pull request
Apr 22, 2024
devangjhabakh
pushed a commit
to cdouglas/iceberg
that referenced
this pull request
Apr 22, 2024
…read from a branch on the Flink Iceberg Source (apache#9627)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, we are now able to specify a branch when reading with the Flink Iceberg Source