Flink: backport #9381 to 1.17 and 1.16 for Migrate subclasses of FlinkCatalogTestBase to JUnit5 #9598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…se for migration to JUnit5
…f FlinkCatalogTestBase to JUnit5
rodmeneses
force-pushed
the
backportTests
branch
from
47b29c8
to
ca78564
Compare
pvary
approved these changes
Feb 2, 2024
rodmeneses
added a commit
to rodmeneses/iceberg
that referenced
this pull request
Feb 2, 2024
…of FlinkCatalogTestBase to JUnit5 (apache#9598)
devangjhabakh
pushed a commit
to cdouglas/iceberg
that referenced
this pull request
Apr 22, 2024
…of FlinkCatalogTestBase to JUnit5 (apache#9598)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flink/v1.16/flink/src/test/java/org/apache/iceberg/flink/TestFlinkCatalogTable.javaa. Missing extra lines in 2 unit tests
b. Lots of unit tests on 1.18 related to alter column that are not to be migrated to 1.16