#9073 Junit 4 tests switched to JUnit 5 #9793
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2. refactor: DataTestHelpers from Junit4 to Junit5 3. refactor: DeleteReadTests from Junit4 to Junit5 4. refactor: RecordWrapperTest from Junit4 to Junit5 5. refactor: TestDataFileIndexStatsFilters from Junit4 to Junit5 6. refactor: TestGenericAppenderFactory from Junit4 to Junit5 7. refactor: TestGenericData from Junit4 to Junit5 8. refactor: TestGenericReaderDeletes from Junit4 to Junit5 9. refactor: TestGenericReadProjection from Junit4 to Junit5 10. refactor: TestGenericRecord from Junit4 to Junit5 11. refactor: TestLocalScan from Junit4 to Junit5 12. refactor: TestMergingMetrics from Junit4 to Junit5 13. refactor: TestMetricsRowGroupFilter from Junit4 to Junit5 14. refactor: TestMetricsRowGroupFilterTypes from Junit4 to Junit5 15. refactor: TestOrcDataWriter from Junit4 to Junit5 16. refactor: TestOrcRowIterator from Junit4 to Junit5 17. refactor: TestParquetEncryptionWithWriteSupport from Junit4 to Junit5 18. refactor: TestReadProjection from Junit4 to Junit5 19. refactor: TestSingleMessageEncoding from Junit4 to Junit5 20. refactor: TestSplitScan from Junit4 to Junit5 data/src/test/java/org/apache/iceberg/io package classes haven't been refactored because of dependency on other test classes outside of current issue scopes.
nastra
reviewed
Feb 26, 2024
nastra
reviewed
Feb 26, 2024
nastra
reviewed
Feb 26, 2024
data/src/test/java/org/apache/iceberg/data/DataTestHelpers.java
Outdated
Show resolved
Hide resolved
nastra
reviewed
Feb 26, 2024
data/src/test/java/org/apache/iceberg/data/DeleteReadTests.java
Outdated
Show resolved
Hide resolved
nastra
reviewed
Feb 26, 2024
data/src/test/java/org/apache/iceberg/data/DeleteReadTests.java
Outdated
Show resolved
Hide resolved
nastra
reviewed
Feb 26, 2024
2. fixed: RecordWrapperTest 3. fixed: DataTestHelpers 4. fixed: DeleteReadTests 5. fixed: DataTest
nastra
reviewed
Mar 28, 2024
data/src/test/java/org/apache/iceberg/TestGenericAppenderFactory.java
Outdated
Show resolved
Hide resolved
|
@igoradulian are you planning on updating this PR? There are a bunch of import changes that would need to be reverted. Also make sure to run |
2. refactor: DataTestHelpers from Junit4 to Junit5 3. refactor: DeleteReadTests from Junit4 to Junit5 4. refactor: RecordWrapperTest from Junit4 to Junit5 5. refactor: TestDataFileIndexStatsFilters from Junit4 to Junit5 6. refactor: TestGenericAppenderFactory from Junit4 to Junit5 7. refactor: TestGenericData from Junit4 to Junit5 8. refactor: TestGenericReaderDeletes from Junit4 to Junit5 9. refactor: TestGenericReadProjection from Junit4 to Junit5 10. refactor: TestGenericRecord from Junit4 to Junit5 11. refactor: TestLocalScan from Junit4 to Junit5 12. refactor: TestMergingMetrics from Junit4 to Junit5 13. refactor: TestMetricsRowGroupFilter from Junit4 to Junit5 14. refactor: TestMetricsRowGroupFilterTypes from Junit4 to Junit5 15. refactor: TestOrcDataWriter from Junit4 to Junit5 16. refactor: TestOrcRowIterator from Junit4 to Junit5 17. refactor: TestParquetEncryptionWithWriteSupport from Junit4 to Junit5 18. refactor: TestReadProjection from Junit4 to Junit5 19. refactor: TestSingleMessageEncoding from Junit4 to Junit5 20. refactor: TestSplitScan from Junit4 to Junit5 data/src/test/java/org/apache/iceberg/io package classes haven't been refactored because of dependency on other test classes outside of current issue scopes.
2. fixed: RecordWrapperTest 3. fixed: DataTestHelpers 4. fixed: DeleteReadTests 5. fixed: DataTest
nastra
reviewed
Apr 2, 2024
data/src/test/java/org/apache/iceberg/data/DataTestHelpers.java
Outdated
Show resolved
Hide resolved
nastra
reviewed
Apr 3, 2024
data/src/test/java/org/apache/iceberg/data/DeleteReadTests.java
Outdated
Show resolved
Hide resolved
nastra
reviewed
Apr 3, 2024
data/src/test/java/org/apache/iceberg/data/DeleteReadTests.java
Outdated
Show resolved
Hide resolved
nastra
reviewed
Apr 3, 2024
data/src/test/java/org/apache/iceberg/data/DeleteReadTests.java
Outdated
Show resolved
Hide resolved
nastra
reviewed
Apr 3, 2024
data/src/test/java/org/apache/iceberg/data/TestDataFileIndexStatsFilters.java
Outdated
Show resolved
Hide resolved
nastra
reviewed
Apr 3, 2024
data/src/test/java/org/apache/iceberg/data/TestGenericReaderDeletes.java
Outdated
Show resolved
Hide resolved
nastra
reviewed
Apr 3, 2024
data/src/test/java/org/apache/iceberg/data/TestGenericRecord.java
Outdated
Show resolved
Hide resolved
nastra
reviewed
Apr 3, 2024
data/src/test/java/org/apache/iceberg/data/avro/TestSingleMessageEncoding.java
Outdated
Show resolved
Hide resolved
nastra
requested changes
Apr 3, 2024
There was a problem hiding this comment.
@igoradulian there are a bunch of unnecessary changes on the PR. Also all assertions should be using AssertJ.
@igoradulian please let me know if you're planning to address this. We'd like to convert tests to JUnit5 in the iceberg-data module rather sooner than later
|
@nastra yes, I'm gonna made changes you proposed. In majority changes I switched Junit4 to Junit5 not AssertJ because it was said to switch to Junit5. Anyway, thank you for your comments I'm going to make changes and update PR asap. |
Thanks, that sounds great. Also see https://iceberg.apache.org/contribute/#assertj |
nastra
reviewed
Apr 30, 2024
data/src/test/java/org/apache/iceberg/data/orc/TestGenericReadProjection.java
Outdated
Show resolved
Hide resolved
nastra
reviewed
Apr 30, 2024
data/src/test/java/org/apache/iceberg/data/avro/TestGenericReadProjection.java
Outdated
Show resolved
Hide resolved
nastra
reviewed
Apr 30, 2024
data/src/test/java/org/apache/iceberg/data/parquet/TestGenericReadProjection.java
Outdated
Show resolved
Hide resolved
nastra
reviewed
Apr 30, 2024
data/src/test/java/org/apache/iceberg/data/orc/TestOrcRowIterator.java
Outdated
Show resolved
Hide resolved
…tor.java Co-authored-by: Eduard Tudenhoefner <etudenhoefner@gmail.com>
…ReadProjection.java Co-authored-by: Eduard Tudenhoefner <etudenhoefner@gmail.com>
…Projection.java Co-authored-by: Eduard Tudenhoefner <etudenhoefner@gmail.com>
…dProjection.java Co-authored-by: Eduard Tudenhoefner <etudenhoefner@gmail.com>
…ageEncoding.java Co-authored-by: Eduard Tudenhoefner <etudenhoefner@gmail.com>
Co-authored-by: Eduard Tudenhoefner <etudenhoefner@gmail.com>
…atsFilters.java Co-authored-by: Eduard Tudenhoefner <etudenhoefner@gmail.com>
Co-authored-by: Eduard Tudenhoefner <etudenhoefner@gmail.com>
Co-authored-by: Eduard Tudenhoefner <etudenhoefner@gmail.com>
…atsFilters.java Co-authored-by: Eduard Tudenhoefner <etudenhoefner@gmail.com>
|
@nastra please review last updates |
nastra
reviewed
May 14, 2024
nastra
reviewed
May 14, 2024
nastra
reviewed
May 14, 2024
nastra
reviewed
May 14, 2024
nastra
reviewed
May 14, 2024
nastra
reviewed
May 14, 2024
data/src/test/java/org/apache/iceberg/data/avro/TestSingleMessageEncoding.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Eduard Tudenhoefner <etudenhoefner@gmail.com>
Co-authored-by: Eduard Tudenhoefner <etudenhoefner@gmail.com>
|
@nastra please review last changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
data/src/test/java/org/apache/iceberg/io package classes haven't been refactored because of dependency on other test classes outside of current issue scopes.