IGNITE-15356 .NET: Add basic thin client #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…server, fix message length on client
isapego
approved these changes
Sep 7, 2021
| prefixWriter.Write(7); | ||
| prefixWriter.Write(8); | ||
| prefixWriter.Write(9); | ||
| writer.Flush(); |
There was a problem hiding this comment.
Why writer and not prefixWriter here?
There was a problem hiding this comment.
Good catch, fixed. Flush is not always necessary, we got lucky here, but it should always be called.
| private int _index; | ||
|
|
||
| /** Index within the array. */ | ||
| private int _index2; |
There was a problem hiding this comment.
Probably needs a better name.
Comment on lines
101
to
114
| byte d = jBytes[15]; | ||
| byte e = jBytes[14]; | ||
| byte f = jBytes[13]; | ||
| byte g = jBytes[12]; | ||
| byte h = jBytes[11]; | ||
| byte i = jBytes[10]; | ||
| byte j = jBytes[9]; | ||
| byte k = jBytes[8]; | ||
|
|
||
| int a = BinaryPrimitives.ReadInt32BigEndian(jBytes[4..]); | ||
| short b = BinaryPrimitives.ReadInt16BigEndian(jBytes[2..]); | ||
| short c = BinaryPrimitives.ReadInt16BigEndian(jBytes); | ||
|
|
||
| return new Guid(a, b, c, d, e, f, g, h, i, j, k); |
There was a problem hiding this comment.
Why GUID serialization format is that weird?
There was a problem hiding this comment.
Guid and UUID use different encoding, see https://en.wikipedia.org/wiki/Universally_unique_identifier#Encoding.
XMLDoc comments updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MessagePack-CSharpandArrayPool.Sharedhttps://cwiki.apache.org/confluence/display/IGNITE/IEP-78+.NET+Thin+Client