IGNITE-15705 election timeout autoadjusting mechanism #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alievmirza
force-pushed
the
ignite-15705
branch
3 times, most recently
from
bd11072
to
26a4e1e
Compare
ascherbakoff
reviewed
Dec 9, 2021
modules/raft/src/main/java/org/apache/ignite/raft/jraft/core/NodeImpl.java
Outdated
Show resolved
Hide resolved
modules/raft/src/integrationTest/java/org/apache/ignite/raft/jraft/core/ItNodeTest.java
Show resolved
Hide resolved
modules/raft/src/main/java/org/apache/ignite/raft/jraft/core/NodeImpl.java
Outdated
Show resolved
Hide resolved
modules/raft/src/main/java/org/apache/ignite/raft/jraft/option/NodeOptions.java
Outdated
Show resolved
Hide resolved
alievmirza
force-pushed
the
ignite-15705
branch
from
26a4e1e
to
a2f1b38
Compare
alievmirza
force-pushed
the
ignite-15705
branch
from
a812547
to
647824b
Compare
alievmirza
changed the title
modules/raft/src/integrationTest/java/org/apache/ignite/raft/jraft/core/ItNodeTest.java
Outdated
Show resolved
Hide resolved
modules/raft/src/main/java/org/apache/ignite/raft/jraft/util/NoopTimeoutStrategy.java
Show resolved
Hide resolved
modules/raft/src/main/java/org/apache/ignite/internal/raft/server/impl/JraftServerImpl.java
Outdated
Show resolved
Hide resolved
modules/raft/src/main/java/org/apache/ignite/internal/raft/server/impl/JraftServerImpl.java
Outdated
Show resolved
Hide resolved
modules/raft/src/main/java/org/apache/ignite/raft/jraft/core/NodeImpl.java
Outdated
Show resolved
Hide resolved
modules/raft/src/main/java/org/apache/ignite/raft/jraft/core/NodeImpl.java
Outdated
Show resolved
Hide resolved
.../raft/src/main/java/org/apache/ignite/raft/jraft/util/ExponentialBackoffTimeoutStrategy.java
Show resolved
Hide resolved
modules/raft/src/main/java/org/apache/ignite/internal/raft/server/impl/JraftServerImpl.java
Outdated
Show resolved
Hide resolved
modules/raft/src/main/java/org/apache/ignite/raft/jraft/core/NodeImpl.java
Outdated
Show resolved
Hide resolved
alievmirza
force-pushed
the
ignite-15705
branch
from
09246fb
to
c3bf6d6
Compare
modules/raft/src/main/java/org/apache/ignite/internal/raft/server/impl/JraftServerImpl.java
Outdated
Show resolved
Hide resolved
modules/raft/src/main/java/org/apache/ignite/internal/raft/server/impl/JraftServerImpl.java
Outdated
Show resolved
Hide resolved
alievmirza
force-pushed
the
ignite-15705
branch
from
2d8ba3f
to
5dbf8c1
Compare
alievmirza
force-pushed
the
ignite-15705
branch
from
5dbf8c1
to
59ce843
Compare
| private static final int DEFAULT_TIMEOUT_MS_MAX = 11_000; | ||
|
|
||
| /** Default max number of a round after which timeout will be adjusted. */ | ||
| public static final long DEFAULT_ROUNDS_WITHOUT_ADJUSTING = 3; |
| private long roundsWithoutAdjusting = DEFAULT_ROUNDS_WITHOUT_ADJUSTING; | ||
|
|
||
| public ExponentialBackoffTimeoutStrategy() { | ||
|
|
There was a problem hiding this comment.
call to this with defaults is missing
| long timeout = options.getElectionTimeoutStrategy().nextTimeout(options.getElectionTimeoutMs(), electionRound); | ||
|
|
||
| if (timeout != options.getElectionTimeoutMs()) { | ||
| LOG.info("Election timeout was adjusted according to {} ", options.getElectionTimeoutStrategy().toString()); |
There was a problem hiding this comment.
toString is not needed
| LOG.info("Election timeout was adjusted according to {} ", options.getElectionTimeoutStrategy().toString()); | ||
| resetElectionTimeoutMs((int) timeout); | ||
| electionAdjusted = true; | ||
| electionRound = 0; |
There was a problem hiding this comment.
Why do we reset electionRound to zero after each succesful adjustment ?
It doesn't seem correct to me. Additionally, I would log this value on each election attempt
There was a problem hiding this comment.
I thought that we could use the logic with several election attempts without adjusting also after the moment when the timeout was adjusted. Motivation is to postpone a moment when we reach the maximum election timeout.
Seems, that logic without resetting is more clear, I'll revert this change.
ascherbakoff
approved these changes
Jan 26, 2022
ygerzhedovich
pushed a commit
that referenced
this pull request
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/IGNITE-15705