IGNITE-12442: Fix unnecessary sync on PagesCache. #7147
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -2033,6 +2033,9 @@ public synchronized boolean add(long pageId) { | |||
| int stripeIdx = (int)pageId & (STRIPES_COUNT - 1); | |||
|
|
|||
| synchronized (stripeLocks[stripeIdx]) { | |||
| if (size >= MAX_SIZE) | |||
There was a problem hiding this comment.
It's a redundant check. There already exists a stripe size check under the lock.
There was a problem hiding this comment.
not this, but upper, if so - i agree.
zstan
force-pushed
the
ignite-12442
branch
2 times, most recently
from
84a6fc0
to
96481aa
Compare
asfgit
pushed a commit
that referenced
this pull request
Dec 24, 2019
Signed-off-by: Aleksey Plekhanov <plehanov.alex@gmail.com> (cherry picked from commit dec87bf)
alex-plekhanov
pushed a commit
to alex-plekhanov/ignite
that referenced
this pull request
Dec 26, 2019
tledkov
pushed a commit
to gridgain/apache-ignite
that referenced
this pull request
Jan 21, 2020
…AL records. IGNITE-12442 Fix unnecessary sync on PagesList.PagesCache - Fixes apache#7147. IGNITE-12254 IO errors during write header of WAL files in FSYNC mode should be handled by failure handler.
zstan
added a commit
to gridgain/apache-ignite
that referenced
this pull request
Jan 24, 2020
…AL records. IGNITE-12442 Fix unnecessary sync on PagesList.PagesCache - Fixes apache#7147. IGNITE-12254 IO errors during write header of WAL files in FSYNC mode should be handled by failure handler.
zstan
added a commit
to gridgain/apache-ignite
that referenced
this pull request
Jan 27, 2020
…AL records. IGNITE-12442 Fix unnecessary sync on PagesList.PagesCache - Fixes apache#7147. IGNITE-12254 IO errors during write header of WAL files in FSYNC mode should be handled by failure handler.
ingvard
pushed a commit
to gridgain/apache-ignite
that referenced
this pull request
Feb 7, 2020
…AL records. IGNITE-12442 Fix unnecessary sync on PagesList.PagesCache - Fixes apache#7147. IGNITE-12254 IO errors during write header of WAL files in FSYNC mode should be handled by failure handler.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.