IGNITE-12555 .NET: Fix SerializableSerializer performance #7285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use cached binary metadata when possible: route all metadata through `Marshaller`, handle caching there. Before the fix, we had a `IBinaryProcessor.GetBinaryType` call for every deserialized object that implements `ISerializable`, which caused huge performance drop, especially for thin client where every call is a network operation. The most common `ISerializable` type is `DateTime`. Perf measurements: * `GetAllEmployeesBenchmark` +56% * `ThinClientGetAllEmployeesBenchmark` +2000% * `GetBenchmark` +30% * `ThinClientGetBenchmark` +20% (cherry picked from commit a4d69dc)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use cached binary metadata when possible: route all metadata through
Marshaller, handle caching there.Before the fix, we had a
IBinaryProcessor.GetBinaryTypecall for every deserialized object that implementsISerializable, which caused huge performance drop, especially for thin client where every call is a network operation. The most commonISerializabletype isDateTime.Perf measurements:
GetAllEmployeesBenchmark+56%ThinClientGetAllEmployeesBenchmark+2000%GetBenchmark+30%ThinClientGetBenchmark+20%