IGNITE-15779 .NET: Fix release and nightly builds #9508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ivandasch
commented
Oct 21, 2021
•
ivandasch
commented
- Fix build.ps1 to pack example sources without building them
- Fix nightly build version for nuget packages
- Add explicit PackageId to csproj files
ivandasch
changed the title
ivandasch
force-pushed
the
ignite-15799
branch
from
f832322
to
19bb961
Compare
ivandasch
force-pushed
the
ignite-15799
branch
from
19bb961
to
89efe04
Compare
ptupitsyn
requested changes
Oct 22, 2021
| // This function cuts excessive part of version. | ||
| function setCutClientVersion(dest, source) { | ||
| var value = project.getProperty(source); | ||
| var digitVer = /\d+\.\d+\.\d+/.exec(value); |
There was a problem hiding this comment.
I'm not sure it is correct to throw away a part of the version like this. Especially for nightly builds, we should pack a pre-release version, not a release one. Pre-release version is any version with a suffix like -nightly.
There was a problem hiding this comment.
It is not possible, unfortunately. AssemblyVersion must contain at most 4 positive numbers, less than max uint16.
This regex just throw away current date, but it is preserved in zip archive of nugets. AFAIK nugets are published to some private repo (myget), so is it the real problem?
ptupitsyn
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.