Skip to content

Commit

Permalink
IMPALA-8879: upgrade bootstrap for debug page to 4.3.1
Browse files Browse the repository at this point in the history
Also upgrade DataTables to 1.10.18 at the same time..

They were obtained from https://datatables.net/download/
and https://getbootstrap.com/docs/4.3/getting-started/download/.

Included the version number in the css and js filenames to
avoid potential issues with stale versions being cached
(I got tripped up by this).

I had to do some additional work to get the UI to look right
after the upgrade:
* added additional style classes to HTML elements for nav and
  breadcrumb styles - these are required in bootstrap 4.
* added styling for plan visualisation graph for it to
  appear similar to the old graph.
* Added styling for <pre> to get box around text.

Testing:
Manually clicked through the web UI to see if anything looked
wrong or didn't function correctly.

Change-Id: Ib58f407574f590825d208424a8c0fd101b0a19a7
Reviewed-on: http://gerrit.cloudera.org:8080/14119
Reviewed-by: Tim Armstrong <tarmstrong@cloudera.com>
Reviewed-by: Quanlong Huang <huangquanlong@gmail.com>
Tested-by: Impala Public Jenkins <impala-public-jenkins@cloudera.com>
  • Loading branch information
Tim Armstrong authored and Impala Public Jenkins committed Aug 31, 2019
1 parent b7dfc18 commit b148481
Show file tree
Hide file tree
Showing 69 changed files with 14,908 additions and 21,057 deletions.
20 changes: 15 additions & 5 deletions .gitattributes
@@ -1,20 +1,30 @@
# Marking minified JS files prevents long lines from showing up in "git grep".
# Marking minified JS, CSS, etc, files prevents long lines from showing up in "git grep".
tests/comparison/leopard/static/css/bootstrap.css binary
tests/comparison/leopard/static/css/bootstrap.css.map binary
tests/comparison/leopard/static/css/bootstrap.min.css binary
tests/comparison/leopard/static/css/bootstrap-theme.min.css binary
tests/comparison/leopard/static/css/bootstrap-theme.css.map binary
tests/comparison/leopard/static/js/bootstrap.js binary
tests/comparison/leopard/static/js/bootstrap.min.js binary
tests/comparison/leopard/static/js/highlight.pack.js binary
www/bootstrap/css/bootstrap.css binary
www/bootstrap/css/bootstrap-4.3.1.min.css binary
www/bootstrap/css/bootstrap.css.map binary
www/bootstrap/css/bootstrap.min.css binary
www/bootstrap/css/bootstrap.min.css.map binary
www/bootstrap/js/bootstrap.js binary
www/bootstrap/js/bootstrap.min.js
www/bootstrap/js/bootstrap.min.js binary
www/d3.v3.min.js binary
www/dagre-d3.min.js binary
www/DataTables-1.10.12/js/dataTables.bootstrap.min.js binary
www/DataTables-1.10.12/js/dataTables.foundation.min.js binary
www/DataTables-1.10.12/js/dataTables.jqueryui.min.js binary
www/DataTables-1.10.12/js/jquery.dataTables.min.js binary
www/DataTables-1.10.18/js/dataTables.bootstrap.min.js binary
www/DataTables-1.10.18/js/dataTables.bootstrap4.min.js biinary
www/DataTables-1.10.18/js/dataTables.foundation.min.js binary
www/DataTables-1.10.18/js/dataTables.jqueryui.min.js binary
www/DataTables-1.10.18/js/dataTables.semanticui.min.js binary
www/DataTables-1.10.18/js/jquery.dataTables.min.js binary
www/datatables.min.js binary
www/datatables-1.10.18.min.js binary
www/datatables-1.10.18.min.css binary
www/highlight/highlight.pack.js binary
www/jquery/jquery-3.4.1.min.js binary
3 changes: 1 addition & 2 deletions bin/rat_exclude_files.txt
Expand Up @@ -31,9 +31,8 @@ be/src/thirdparty/mpfit/*
be/src/kudu/gutil
www/highlight/*
www/DataTables*/*
www/datatables.*
www/datatables-1.10.18.*
www/bootstrap/css/bootstrap*
www/bootstrap/fonts/glyphicons-halflings*
www/bootstrap/js/bootstrap*
tests/comparison/leopard/static/css/bootstrap*
tests/comparison/leopard/static/fonts/glyphicons-halflings*
Expand Down
1 change: 0 additions & 1 deletion www/DataTables-1.10.12/css/dataTables.bootstrap.min.css

This file was deleted.

0 comments on commit b148481

Please sign in to comment.