Skip to content

Commit

Permalink
Revert "IMPALA-4829: Change default Kudu read behavior for "RYW""
Browse files Browse the repository at this point in the history
Reverting until we have a fix for KUDU-1869:
Scans do not work with hybrid time disabled and snapshot
reads enabled

This reverts commit 32ff959.

Change-Id: I995dec543946c9e0f79bc5b7e82568060a9d8262
Reviewed-on: http://gerrit.cloudera.org:8080/5970
Reviewed-by: Matthew Jacobs <mj@cloudera.com>
Tested-by: Impala Public Jenkins
  • Loading branch information
Matthew Jacobs authored and Impala Public Jenkins committed Feb 15, 2017
1 parent ffd297b commit bd1d445
Showing 1 changed file with 6 additions and 7 deletions.
13 changes: 6 additions & 7 deletions be/src/exec/kudu-scanner.cc
Original file line number Diff line number Diff line change
Expand Up @@ -44,9 +44,8 @@ using kudu::client::KuduScanBatch;
using kudu::client::KuduSchema;
using kudu::client::KuduTable;

DEFINE_string(kudu_read_mode, "READ_AT_SNAPSHOT", "(Advanced) Sets the Kudu scan "
"ReadMode. Supported Kudu read modes are READ_LATEST and READ_AT_SNAPSHOT. Invalid "
"values result in using READ_AT_SNAPSHOT.");
DEFINE_string(kudu_read_mode, "READ_LATEST", "(Advanced) Sets the Kudu scan ReadMode. "
"Supported Kudu read modes are READ_LATEST and READ_AT_SNAPSHOT.");
DEFINE_bool(pick_only_leaders_for_tests, false,
"Whether to pick only leader replicas, for tests purposes only.");
DEFINE_int32(kudu_scanner_keep_alive_period_sec, 15,
Expand All @@ -57,7 +56,7 @@ DECLARE_int32(kudu_operation_timeout_ms);

namespace impala {

const string MODE_READ_LATEST = "READ_LATEST";
const string MODE_READ_AT_SNAPSHOT = "READ_AT_SNAPSHOT";

KuduScanner::KuduScanner(KuduScanNode* scan_node, RuntimeState* state)
: scan_node_(scan_node),
Expand Down Expand Up @@ -138,9 +137,9 @@ Status KuduScanner::OpenNextScanToken(const string& scan_token) {
"Could not set replica selection.");
}
kudu::client::KuduScanner::ReadMode mode =
MODE_READ_LATEST == FLAGS_kudu_read_mode ?
kudu::client::KuduScanner::READ_LATEST :
kudu::client::KuduScanner::READ_AT_SNAPSHOT;
MODE_READ_AT_SNAPSHOT == FLAGS_kudu_read_mode ?
kudu::client::KuduScanner::READ_AT_SNAPSHOT :
kudu::client::KuduScanner::READ_LATEST;
KUDU_RETURN_IF_ERROR(scanner_->SetReadMode(mode), "Could not set scanner ReadMode");
KUDU_RETURN_IF_ERROR(scanner_->SetTimeoutMillis(FLAGS_kudu_operation_timeout_ms),
"Could not set scanner timeout");
Expand Down

0 comments on commit bd1d445

Please sign in to comment.