Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-713] EmrCreateJobFlowOperator and EmrAddStepsOperator attributes are not jinjafied #3016

Closed
wants to merge 1 commit into from

Conversation

Swalloow
Copy link
Contributor

@Swalloow Swalloow commented Feb 8, 2018

Make sure you have checked all steps below.

JIRA

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"
  • Passes git diff upstream/master -u -- "*.py" | flake8 --diff

@Swalloow
Copy link
Contributor Author

Swalloow commented Feb 8, 2018

@Fokko Done!

@Swalloow Swalloow closed this Feb 8, 2018
@Swalloow Swalloow reopened this Feb 8, 2018
@codecov-io
Copy link

codecov-io commented Feb 8, 2018

Codecov Report

Merging #3016 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3016   +/-   ##
=======================================
  Coverage   73.14%   73.14%           
=======================================
  Files         177      177           
  Lines       12394    12394           
=======================================
  Hits         9066     9066           
  Misses       3328     3328

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0deb50...f10d70d. Read the comment docs.

@asfgit asfgit closed this in 44551e2 Feb 9, 2018
aliceabe pushed a commit to aliceabe/incubator-airflow that referenced this pull request Jan 3, 2019
To dynamically templat the fields of the Emr Operators, we need
to pass the fields to jinja

Closes apache#3016 from Swalloow/emr-jinjafied
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants