Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-2088] Fix duplicate keys in MySQL to GCS Helper function #3022

Closed
wants to merge 1 commit into from

Conversation

kaxil
Copy link
Member

@kaxil kaxil commented Feb 9, 2018

Make sure you have checked all steps below.

JIRA

Description

  • Here are some details about my PR, including screenshots of any UI changes:
  • Remove the duplicate key in MySqlToGoogleCloudStorageOperator in the type_map helper function that maps from MySQL fields to BigQuery fields.

image

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:
    Minor change

Commits

  • My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"
  • Passes git diff upstream/master -u -- "*.py" | flake8 --diff

- Remove the duplicate key in `MySqlToGoogleCloudStorageOperator` in the `type_map` helper function that maps from MySQL fields to BigQuery fields.
@codecov-io
Copy link

codecov-io commented Feb 9, 2018

Codecov Report

Merging #3022 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3022   +/-   ##
=======================================
  Coverage   73.19%   73.19%           
=======================================
  Files         177      177           
  Lines       12415    12415           
=======================================
  Hits         9087     9087           
  Misses       3328     3328

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6973b1...af43e09. Read the comment docs.

@Fokko
Copy link
Contributor

Fokko commented Feb 9, 2018

Thanks!

@asfgit asfgit closed this in 759d8f8 Feb 9, 2018
@kaxil kaxil deleted the duplicate-keys-fix branch February 12, 2018 16:34
aliceabe pushed a commit to aliceabe/incubator-airflow that referenced this pull request Jan 3, 2019
- Remove the duplicate key in
`MySqlToGoogleCloudStorageOperator` in the
`type_map` helper function that maps from MySQL
fields to BigQuery fields.

Closes apache#3022 from kaxil/duplicate-keys-fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants