[AIRFLOW-3216] HiveServer2Hook need a password with LDAP authentication

[jongyoul]

Jira

• https://issues.apache.org/jira/browse/AIRFLOW-3216

Description

• To use HiveServer2Hook under LDAP environment, authentication information should be passed to pyhive while creating a connection. It missed.

Tests

• This change is quite simple and I've tested it in my own environment with LDAP

Commits

• My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
  1. Subject is separated from body by a blank line
  2. Subject is limited to 50 characters (not including Jira issue reference)
  3. Subject does not end with a period
  4. Subject uses the imperative mood ("add", not "adding")
  5. Body wraps at 72 characters
  6. Body explains "what" and "why", not "how"

Documentation

• In case of new functionality, my PR adds documentation that describes how to use it.
  • When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.

Code Quality

• Passes flake8

[codecov-io]

Codecov Report

Merging #4057 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #4057   +/-   ##
======================================
  Coverage    78.1%   78.1%           
======================================
  Files         201     201           
  Lines       16464   16464           
======================================
  Hits        12859   12859           
  Misses       3605    3605

Impacted Files	Coverage Δ
airflow/hooks/hive_hooks.py	75.26% <ø> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e947c6c...63dacb6. Read the comment docs.

[jongyoul]

Please review this simple PR.

[Fokko]

LGTM, thanks @jongyoul

This looks good: https://github.com/dropbox/PyHive/blob/2c2446bf905ea321aac9dcdd3fa033909ff0b0b5/pyhive/hive.py#L101

Maybe we could add a test as well?

[jongyoul]

Thanks for the review. I'll try to add a test case about passing password.

[Fokko]

Thanks @jongyoul

[bolkedebruin]

Any update @jongyoul ?

[jongyoul]

@Fokko @bolkedebruin Sorry for the late reply. I've added a test case. BTW, the failed one doesn't look related to my changes. Could you please confirm it?

[Fokko]

@jongyoul Could you rebase onto latest master? That one looks to be okay: https://travis-ci.org/apache/incubator-airflow

[jongyoul]

@Fokko Rebased.

[jongyoul]

CI become green. Please check this PR.

[Fokko]

Thanks @jongyoul

[jongyoul]

@Fokko Hello, BTW, could you please tell me the schedule of merging this PR? I saw the status of Jira issue has been changed.

[kaxil]

Thanks @jongyoul