Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic Connector Overrides profile picture #857

Closed
surapuramakhil opened this issue Mar 18, 2024 · 5 comments
Closed

Basic Connector Overrides profile picture #857

surapuramakhil opened this issue Mar 18, 2024 · 5 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers
Milestone

Comments

@surapuramakhil
Copy link
Contributor

For an existing account where user has already set his profile picture. A login using connector will override profile picture.

Ideal:
Profile picture should be taken from connector only if the user hasn't set his picture.

@LinkinStars
Copy link
Member

You're right. If a user has already set their avatar, it shouldn't be overwritten. Thank you for your feedback. BTW, this issue is not related to the Basic Connector plugin, but rather with the Answer itself. I will transfer this issue to the Answer.

@LinkinStars LinkinStars transferred this issue from apache/incubator-answer-plugins Mar 18, 2024
@LinkinStars LinkinStars added the good first issue Good for newcomers label Mar 18, 2024
@LinkinStars LinkinStars added this to the v1.3.0 milestone Mar 18, 2024
@Octobug
Copy link
Contributor

Octobug commented Mar 18, 2024

@LinkinStars I would like to try to fix this issue. Thanks!

P.S. Shouldn't it be labeled as a bug? 👀

@LinkinStars LinkinStars added the bug Something isn't working label Mar 19, 2024
@Octobug
Copy link
Contributor

Octobug commented Mar 19, 2024

@surapuramakhil @LinkinStars Is it possible to setup Google or GitHub connect process in development? I tried these two providors but both ended up a /50x page 😂

@surapuramakhil
Copy link
Contributor Author

surapuramakhil commented Mar 19, 2024

Yes, it is. It is possible to set up Google or GitHub connect process in development.

I actually stated with Google connector, but facing this apache/incubator-answer-plugins#65

I have fallen back to basic connector as per this comment apache/incubator-answer-plugins#65 (comment)

Try using basic connector, it works for sure.

@Octobug
Copy link
Contributor

Octobug commented Mar 19, 2024

Yes, it is. It is possible to set up Google or GitHub connect process in development.

I actually stated with Google connector, but facing this apache/incubator-answer-plugins#65

I have fallen back to basic connector as per this comment apache/incubator-answer-plugins#65 (comment)

Try using basic connector, it works for sure.

@surapuramakhil

Thank you! I'll try the basic connector later. I also encountered this "does not provide a unique UserID" problem when using Google connector. I thought maybe it only happened in development for there being a frontend port and a backend port.

------Update------

The basic connector with Google credentials works in development.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants