This repository has been archived by the owner on Jul 17, 2018. It is now read-only.
ARIA-136-ctx-binary-doesnt-get-installed-via-pip-install #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
asfgit
force-pushed
the
ARIA-136-ctx-binary-doesnt-get-installed-via-pip-install
branch
from
6fb177e
to
4042c9a
Compare
ran-z
reviewed
Apr 3, 2017
| custom_cmd.command.run(custom_cmd) | ||
|
|
||
|
|
||
| class InstallCommand(install): |
There was a problem hiding this comment.
why not have a base CustomCommand class,
have all the private functions in it as well,
and have two subclasses which only set command?
There was a problem hiding this comment.
Thats where is was coming from at first. But the problem is with the class attributes...
ran-z
reviewed
Apr 3, 2017
| return command.boolean_options + ['skip-ctx'] | ||
|
|
||
|
|
||
| def _initialize_options(custom_cmd): |
asfgit
force-pushed
the
ARIA-136-ctx-binary-doesnt-get-installed-via-pip-install
branch
from
4042c9a
to
369323b
Compare
asfgit
deleted the
ARIA-136-ctx-binary-doesnt-get-installed-via-pip-install
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.