-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BEAM-77] Directory reorganization #72
Conversation
Move Java SDK from "sdk/" into "sdks/java/core".
Move Java SDK-specific Javadoc information from "javadoc/" into "sdks/java/javadoc".
Move Java examples from "examples/" into "examples/java".
Move Java 8 examples from "java8examples/" into "examples/java8/".
Move Java 8-specific tests from "java8tests" into "sdks/java/java8tests/".
Move Java-specific archetypes from "maven-archetypes/" into "sdks/java/maven-archetypes/".
Also, performing an "offline" review of the new changes and pushing is perfectly safe. I found it easiest to read the changes via LGTM, though the Jenkins failure looks like it might be a real breakage of some sort. |
The changes LGTM. Travis passes fully, but Jenkins fails only on the archetypes. I spent an hour trying to fix, but was not successful, and it looks like the cause may be related to the I think that in the interest of getting the big move in we should go ahead and merge, and fixup the Jenkins archetype issue as we go. It may require updating the version of Maven in Jenkins. |
asfgit is still slow, but this has been merged. Travis is still useful as a signal of build success, and jenkins results should be manually inspected. |
And I've filed https://issues.apache.org/jira/browse/BEAM-148 for the Jenkins test issue. |
Thanks @dhalperi and @kennknowles. |
LGTM from the Flink side. |
This pull requests reorganizes directory structure. This is the first step towards the organization proposed in the document shared a few weeks ago.
We'll try to merge this quickly to limit complicated merges. This shouldn't prevent feedback -- please keep it coming -- we'll just address such feedback in a follow-up commit.
This is the first step only, and there are many things that are incomplete:
pom.xml
files; they are not added yet.There's nothing in this pull request that renames Dataflow to Beam; it just moves files around without changing the content.
Aside:
asfgit
is very slow; the pull request pulls in a few commits merged into Apache repository that the GitHub mirror hasn't picked up yet. This should be properly rebased prior to merge.R: @dhalperi; everyone else very welcome.