fix: split the collector into collector+extractor #6564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d4x1
reviewed
Dec 7, 2023
| EntryPoint: CollectAndExtractDeployments, | ||
| var CollectDeploymentsMeta = plugin.SubTaskMeta{ | ||
| Name: "CollectDeployments", | ||
| EntryPoint: CollectDeployments, | ||
| EnabledByDefault: true, | ||
| Description: "collect and extract github deployments to raw and tool layer from GithubGraphql api", |
There was a problem hiding this comment.
Description should be updated too.
| return nil, err | ||
| } | ||
| accounts := apiAccount.Users | ||
| results := make([]interface{}, 0, 1) |
There was a problem hiding this comment.
var result []interface is more idiomatic.
| // ResponseParser's return will be stored to tool layer. So it's called CollectorAndExtractor. | ||
| func CollectAndExtractDeployments(taskCtx plugin.SubTaskContext) errors.Error { | ||
| func CollectDeployments(taskCtx plugin.SubTaskContext) errors.Error { |
There was a problem hiding this comment.
Comment in line 87 should be updated too.
| githubDeployment, err := convertGithubDeployment(deployment, data.Options.ConnectionId, data.Options.GithubId) | ||
| if err != nil { | ||
| return nil, err | ||
| isFinish := false |
There was a problem hiding this comment.
Can ResponseParser return nil, nil directly?
| //Labels: ``, // not on use | ||
| //RunnerID: ``, // not on use | ||
| //RunnerName: ``, // not on use | ||
| //RunnerGroupID: ``, // not on use |
There was a problem hiding this comment.
I think not on use should be not in use.
| Name: "CollectPr", | ||
| EntryPoint: CollectPr, | ||
| var CollectPrsMeta = plugin.SubTaskMeta{ | ||
| Name: "CollectPrs", |
There was a problem hiding this comment.
Will this name be conflict with tasks in github/tasks?
d4x1
approved these changes
Dec 7, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Dec 7, 2023
* fix: split the collector into collector+extractor * fix: impl * fix: github graphql incremental collector * fix: lint * fix: some detail
|
🤖 cherry pick finished successfully 🎉! |
github-actions
bot
added
the
bot/auto-cherry-pick-completed
abeizn
added a commit
that referenced
this pull request
Dec 7, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fix: split the collector into collector+extractor
Does this close any open issues?
Closes #6495
Screenshots
Include any relevant screenshots here.
Other Information
Any other information that is important to this PR.