Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: gitlab server extract deployment may fail #6754

Merged
merged 1 commit into from
Jan 5, 2024

Conversation

klesh
Copy link
Contributor

@klesh klesh commented Jan 5, 2024

Summary

Related fields might not available on Gitlab Server, this PR simply make them nullable because they are not used in anywhere at this point.

No need to migrate db since they are already Nullable in mysql and postgres by default

image
image

Screenshots

self tested OK
image

Other Information

Any other information that is important to this PR.

Copy link
Contributor

@abeizn abeizn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@abeizn abeizn merged commit 96d1ceb into main Jan 5, 2024
10 checks passed
@abeizn abeizn deleted the kw-gitlab-server-extract-deployment-failure branch January 5, 2024 08:53
Copy link

github-actions bot commented Jan 5, 2024

🤖 cherry pick finished successfully 🎉!

@github-actions github-actions bot added the bot/auto-cherry-pick-completed auto cherry pick completed label Jan 5, 2024
abeizn pushed a commit that referenced this pull request Jan 5, 2024
Co-authored-by: Klesh Wong <zhenmian.huang@merico.dev>
ViktorGrigorov7 pushed a commit to ViktorGrigorov7/incubator-devlake that referenced this pull request Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants