fix:Activate上的before,after排序是有问题的，不起作用 #639
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yuyijq 当前排序实现的问题能描述一下吗？还有当前排序实现的思路和好处？ |
|
退订
在2017年09月21日 14:02，ken.lj 写道：
@yuyijq 当前排序实现的问题能描述一下吗？还有当前排序实现的思路和好处？
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
dubbo原有的排序其实是有bug的，用before/after这种方式，其实是不生效的 |
chickenlj
added
status/feedback-provided
and removed
status/waiting-for-feedback
|
引入太多外部依赖包，不利于dubbo的纯洁 |
|
Please resolve the conflict before we can merge. |
|
Hi, Please update the title and description using English. Dubbo is a global community and we would like the PR to be reviewed by people all over the world. |
|
As FelixLiuSheng has mentioned above, i think this implementation introduces unnecessary guava dependency. I have filed a new issue tracking the "before/after" problem: #1926 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
这个before/after的排序要实现的没问题还是有些复杂，而这种相对排序的功能在实际使用中是比order那种绝对排序更有用的