[CH-375] Enable ch backend tpcds suite #1196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/oap-project/gluten/issues Then could you also rename commit message and pull request title in the following format? See also: |
zhztheplayer
changed the title
zzcclp
reviewed
Mar 24, 2023
| @@ -49,6 +47,73 @@ abstract class GlutenClickHouseTPCDSAbstractSuite extends WholeStageTransformerS | |||
| protected val tpcdsQueries: String | |||
| protected val queriesResults: String | |||
|
|
|||
| protected val tpcdsAllQueries: Seq[String] = | |||
| Range | |||
| .inclusive(24, 99) | |||
zzcclp
reviewed
Mar 24, 2023
| @@ -40,6 +40,20 @@ class GlutenClickHouseTPCDSParquetSuite extends GlutenClickHouseTPCDSAbstractSui | |||
| .set("spark.sql.files.openCostInBytes", "134217728") | |||
| } | |||
|
|
|||
| tpcdsAllQueries.foreach( | |||
There was a problem hiding this comment.
add these tests for other suites, GlutenClickHouseTPCDSParquetColumnarShuffleSuite, GlutenClickHouseTPCDSParquetColumnarShuffleAQESuite, GlutenClickHouseTPCDSParquetAQESuite ?
loneylee
force-pushed
the
tpcds
branch
7 times, most recently
from
4126e34
to
5f33e88
Compare
zzcclp
reviewed
Apr 4, 2023
| }) | ||
|
|
||
| protected val excludedTpcdsQueries: Set[String] = Set( | ||
| "q2", |
There was a problem hiding this comment.
please rebase and try to run q2, q10, q35, q49, a59.
loneylee
added a commit
to loneylee/gluten
that referenced
this pull request
Apr 7, 2023
This reverts commit 2685c1f.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
How was this patch tested?