Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CH] enable replaceSortAggWithHashAgg #3658

Merged
merged 1 commit into from
Dec 12, 2023
Merged

[CH] enable replaceSortAggWithHashAgg #3658

merged 1 commit into from
Dec 12, 2023

Conversation

exmy
Copy link
Contributor

@exmy exmy commented Nov 9, 2023

What changes were proposed in this pull request?

How was this patch tested?

CI

Copy link

github-actions bot commented Nov 9, 2023

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/oap-project/gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

Copy link

github-actions bot commented Nov 9, 2023

Run Gluten Clickhouse CI

Copy link

Run Gluten Clickhouse CI

@exmy
Copy link
Contributor Author

exmy commented Nov 14, 2023

failed ut due to #3706

Copy link

Run Gluten Clickhouse CI

Copy link

Run Gluten Clickhouse CI

Copy link

Run Gluten Clickhouse CI

Copy link

Run Gluten Clickhouse CI

1 similar comment
Copy link

Run Gluten Clickhouse CI

zzcclp
zzcclp previously approved these changes Nov 17, 2023
Copy link
Contributor

@zzcclp zzcclp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

github-actions bot commented Dec 8, 2023

Run Gluten Clickhouse CI

Copy link

Run Gluten Clickhouse CI

Copy link

Run Gluten Clickhouse CI

Copy link

Run Gluten Clickhouse CI

Copy link

Run Gluten Clickhouse CI

Copy link
Contributor

@zzcclp zzcclp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zzcclp zzcclp merged commit 9f11335 into apache:main Dec 12, 2023
17 checks passed
@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_3658_time.csv log/native_master_12_11_2023_71ec720d4_time.csv difference percentage
q1 33.86 32.10 -1.768 94.78%
q2 23.47 24.79 1.321 105.63%
q3 38.78 38.42 -0.359 99.07%
q4 39.21 39.90 0.690 101.76%
q5 71.87 72.41 0.541 100.75%
q6 6.99 7.02 0.027 100.39%
q7 87.15 85.38 -1.770 97.97%
q8 87.65 86.65 -0.999 98.86%
q9 121.56 126.76 5.192 104.27%
q10 45.79 46.79 1.002 102.19%
q11 20.12 20.34 0.220 101.09%
q12 24.43 26.95 2.525 110.34%
q13 46.93 45.56 -1.370 97.08%
q14 14.84 18.31 3.470 123.39%
q15 29.91 27.78 -2.131 92.88%
q16 16.06 15.83 -0.228 98.58%
q17 105.17 101.57 -3.603 96.57%
q18 151.95 151.54 -0.404 99.73%
q19 12.67 12.91 0.237 101.87%
q20 28.35 26.84 -1.515 94.66%
q21 223.73 228.06 4.336 101.94%
q22 14.87 13.81 -1.058 92.88%
total 1245.35 1249.71 4.356 100.35%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants