New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GLUTEN-3841][CH] Support spill in 2nd aggregate stage #3772

Merged

liuneng1994 merged 1 commit into apache:main from bigo-sg:scale_agg_2_stage

Dec 11, 2023

Contributor

lgbo-ustc commented Nov 20, 2023 •

edited

Loading

What changes were proposed in this pull request?

(Please fill in changes proposed in this fix)

Fixes: #3841

How was this patch tested?

(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)

unit tests

(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)

github-actions bot commented Nov 20, 2023

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/oap-project/gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

Other pull requests

github-actions bot commented Nov 20, 2023

Run Gluten Clickhouse CI

zhanglistar reviewed

View reviewed changes

cpp-ch/local-engine/Operator/ScalableMergingAggregatedStep.cpp Outdated Show resolved Hide resolved

zhanglistar reviewed

View reviewed changes

cpp-ch/local-engine/Operator/ScalableMergingAggregatedStep.h Outdated Show resolved Hide resolved

zhanglistar reviewed

View reviewed changes

cpp-ch/local-engine/Operator/ScalableMergingAggregatedStep.h Outdated Show resolved Hide resolved

zhanglistar reviewed

View reviewed changes

cpp-ch/local-engine/Operator/ScalableMergingAggregatedStep.cpp Outdated Show resolved Hide resolved

zhanglistar reviewed

View reviewed changes

cpp-ch/local-engine/Operator/ScalableMergingAggregatedStep.cpp Outdated Show resolved Hide resolved

zhanglistar reviewed

View reviewed changes

cpp-ch/local-engine/Operator/ScalableMergingAggregatedStep.cpp Outdated Show resolved Hide resolved

github-actions bot commented Nov 24, 2023

Run Gluten Clickhouse CI

lgbo-ustc force-pushed the scale_agg_2_stage branch from f1343ed to 83c1af3 Compare

November 24, 2023 06:49

github-actions bot commented Nov 24, 2023

Run Gluten Clickhouse CI

lgbo-ustc force-pushed the scale_agg_2_stage branch from 83c1af3 to a98534f Compare

November 24, 2023 06:52

github-actions bot commented Nov 24, 2023

Run Gluten Clickhouse CI

lgbo-ustc changed the title ~~[WIP][CH] Support spill in 2nd aggregate stage~~ [WIP][GLUTEN-3841][CH] Support spill in 2nd aggregate stage

lgbo-ustc force-pushed the scale_agg_2_stage branch from a98534f to 7cab810 Compare

November 24, 2023 06:56

github-actions bot commented Nov 24, 2023

Run Gluten Clickhouse CI

lgbo-ustc force-pushed the scale_agg_2_stage branch from 7cab810 to 0eaf3e7 Compare

November 24, 2023 07:40

github-actions bot commented Nov 24, 2023

Run Gluten Clickhouse CI

lgbo-ustc mentioned this pull request

add a new api in aggregator Kyligence/ClickHouse#468

Merged

1 task

lgbo-ustc force-pushed the scale_agg_2_stage branch from 0eaf3e7 to 7b2042e Compare

November 27, 2023 06:09

github-actions bot commented Nov 27, 2023

Run Gluten Clickhouse CI

lgbo-ustc force-pushed the scale_agg_2_stage branch from 7b2042e to 8c01e3a Compare

November 27, 2023 06:12

github-actions bot commented Nov 27, 2023

Run Gluten Clickhouse CI

lgbo-ustc force-pushed the scale_agg_2_stage branch from 8c01e3a to 597246a Compare

November 27, 2023 09:27

github-actions bot commented Nov 27, 2023

Run Gluten Clickhouse CI

lgbo-ustc force-pushed the scale_agg_2_stage branch from 597246a to 8290035 Compare

November 27, 2023 09:48

github-actions bot commented Nov 27, 2023

Run Gluten Clickhouse CI

lgbo-ustc force-pushed the scale_agg_2_stage branch from 8290035 to 6632d4b Compare

November 27, 2023 10:25

github-actions bot commented Nov 27, 2023

Run Gluten Clickhouse CI

lgbo-ustc force-pushed the scale_agg_2_stage branch from 6632d4b to fd65b64 Compare

November 28, 2023 00:34

lgbo-ustc force-pushed the scale_agg_2_stage branch from 9a1403e to a128644 Compare

December 6, 2023 08:17

github-actions bot commented Dec 6, 2023

Run Gluten Clickhouse CI

lgbo-ustc force-pushed the scale_agg_2_stage branch from a128644 to ba75b5d Compare

December 6, 2023 09:27

github-actions bot commented Dec 6, 2023

Run Gluten Clickhouse CI

lgbo-ustc force-pushed the scale_agg_2_stage branch from ba75b5d to eb475fc Compare

December 7, 2023 01:22

github-actions bot commented Dec 7, 2023

Run Gluten Clickhouse CI

lgbo-ustc force-pushed the scale_agg_2_stage branch from eb475fc to 3f64083 Compare

December 7, 2023 04:28

github-actions bot commented Dec 7, 2023

Run Gluten Clickhouse CI

lgbo-ustc force-pushed the scale_agg_2_stage branch from 3f64083 to 395500d Compare

December 7, 2023 10:06

github-actions bot commented Dec 7, 2023

Run Gluten Clickhouse CI

lgbo-ustc force-pushed the scale_agg_2_stage branch from 395500d to e36be5a Compare

December 7, 2023 10:07

github-actions bot commented Dec 7, 2023

Run Gluten Clickhouse CI

lgbo-ustc force-pushed the scale_agg_2_stage branch from e36be5a to e322089 Compare

December 7, 2023 12:59

github-actions bot commented Dec 7, 2023

Run Gluten Clickhouse CI

lgbo-ustc force-pushed the scale_agg_2_stage branch from e322089 to b7bfd34 Compare

December 8, 2023 01:38

github-actions bot commented Dec 8, 2023

Run Gluten Clickhouse CI

lgbo-ustc force-pushed the scale_agg_2_stage branch from b7bfd34 to d32f7f5 Compare

December 8, 2023 02:44

github-actions bot commented Dec 8, 2023

Run Gluten Clickhouse CI

lgbo-ustc force-pushed the scale_agg_2_stage branch from d32f7f5 to 5852e98 Compare

December 8, 2023 04:30

github-actions bot commented Dec 8, 2023

Run Gluten Clickhouse CI

lgbo-ustc force-pushed the scale_agg_2_stage branch from 5852e98 to 553d72e Compare

December 8, 2023 04:57

github-actions bot commented Dec 8, 2023

Run Gluten Clickhouse CI


          [gluten-3841]

d6fe794

lgbo-ustc force-pushed the scale_agg_2_stage branch from 553d72e to d6fe794 Compare

December 8, 2023 06:30

github-actions bot commented Dec 8, 2023

Run Gluten Clickhouse CI

Contributor Author

lgbo-ustc commented Dec 8, 2023

@liuneng1994 @zzcclp please review this

liuneng1994 approved these changes

View reviewed changes

Contributor

liuneng1994 left a comment

LGTM

liuneng1994 merged commit 71a29be into apache:main

7 checks passed

Contributor Author

lgbo-ustc commented Dec 11, 2023 •

edited

Loading

before

after

lgbo-ustc mentioned this pull request

[CH] Disable streaming aggregating at default since some memory issues #4092

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet