Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GLUTEN-3528][VL] Construct unique & non-overlapping partition/sort keys for window operator #3883

Merged
merged 3 commits into from
Nov 30, 2023

Conversation

PHILO-HE
Copy link
Contributor

@PHILO-HE PHILO-HE commented Nov 29, 2023

To meet Velox's requirement, this PR proposes constructing unique & non-overlapping partition/sort keys for window operator.

Fix #3528.

How was this patch tested?

Added test cases.

Copy link

#3528

@PHILO-HE PHILO-HE merged commit 4a7fd4b into apache:main Nov 30, 2023
17 checks passed
@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_3883_time.csv log/native_master_11_29_2023_0ac1dc42d_time.csv difference percentage
q1 35.44 34.61 -0.835 97.64%
q2 25.16 24.87 -0.292 98.84%
q3 37.97 36.61 -1.359 96.42%
q4 37.20 36.91 -0.295 99.21%
q5 72.77 71.43 -1.338 98.16%
q6 6.58 7.22 0.649 109.87%
q7 85.17 85.50 0.337 100.40%
q8 88.37 88.07 -0.300 99.66%
q9 124.49 127.33 2.842 102.28%
q10 43.94 44.31 0.379 100.86%
q11 20.23 20.45 0.217 101.07%
q12 26.18 27.02 0.843 103.22%
q13 46.10 46.05 -0.053 99.88%
q14 17.93 18.98 1.049 105.85%
q15 26.96 29.21 2.248 108.34%
q16 16.14 15.65 -0.483 97.01%
q17 103.78 101.75 -2.030 98.04%
q18 149.71 150.75 1.040 100.69%
q19 14.43 13.94 -0.485 96.64%
q20 27.80 30.32 2.517 109.05%
q21 224.75 225.21 0.457 100.20%
q22 13.11 13.20 0.096 100.73%
total 1244.19 1249.39 5.202 100.42%

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[VL] Construct unique partition/sort keys and removing overlapping sort key for window plan
3 participants