Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GLUTEN-3924][CORE] Match hive UDF name in case-insensitive mode during expression transformation #3925

Merged
merged 4 commits into from
Dec 7, 2023
Merged

[GLUTEN-3924][CORE] Match hive UDF name in case-insensitive mode during expression transformation #3925

merged 4 commits into from
Dec 7, 2023

Conversation

taiyang-li
Copy link
Contributor

What changes were proposed in this pull request?

(Please fill in changes proposed in this fix)

(Fixes: #3924)

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2023

#3924

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2023

Run Gluten Clickhouse CI

zzcclp
zzcclp previously approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@zzcclp zzcclp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2023

Run Gluten Clickhouse CI

1 similar comment
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2023

Run Gluten Clickhouse CI

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2023

Run Gluten Clickhouse CI

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2023

Run Gluten Clickhouse CI

@PHILO-HE PHILO-HE changed the title [GLUTEN-3924][CORE] case-insensitive matching for hive UDFs during expression transformation [GLUTEN-3924][CORE] Match hive UDF name in case-insensitive mode during expression transformation Dec 6, 2023
baibaichen
baibaichen approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@baibaichen baibaichen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@baibaichen baibaichen merged commit 9c6e77b into apache:main Dec 7, 2023
18 checks passed
@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_3925_time.csv log/native_master_12_06_2023_d6b1e9138_time.csv difference percentage
q1 34.32 33.13 -1.195 96.52%
q2 24.80 25.88 1.081 104.36%
q3 38.50 36.12 -2.381 93.82%
q4 37.07 38.73 1.660 104.48%
q5 70.13 72.19 2.054 102.93%
q6 7.15 7.01 -0.132 98.15%
q7 85.32 84.85 -0.469 99.45%
q8 85.94 87.08 1.132 101.32%
q9 120.59 127.07 6.479 105.37%
q10 44.43 44.57 0.145 100.33%
q11 20.11 20.26 0.153 100.76%
q12 27.74 21.15 -6.593 76.23%
q13 46.33 48.39 2.068 104.46%
q14 18.50 18.86 0.360 101.94%
q15 29.64 27.18 -2.454 91.72%
q16 15.42 15.92 0.504 103.27%
q17 102.80 102.54 -0.264 99.74%
q18 148.26 152.02 3.764 102.54%
q19 14.40 13.90 -0.505 96.49%
q20 27.95 27.91 -0.041 99.85%
q21 225.37 223.84 -1.536 99.32%
q22 13.28 13.24 -0.034 99.75%
total 1238.04 1241.84 3.796 100.31%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baibaichen baibaichen baibaichen approved these changes

@zzcclp zzcclp zzcclp left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CORE] Case-insensitive matching for hive UDFs during expression transformation
4 participants
@taiyang-li @GlutenPerfBot @baibaichen @zzcclp