[GLUTEN-4029][CH]Improve multiIf #4030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Run Gluten Clickhouse CI |
KevinyhZou
force-pushed
the
improve_multi_if
branch
from
4e22c07
to
84e2615
Compare
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
taiyang-li
reviewed
Dec 21, 2023
| const auto * if_node = toFunctionNode(actions_dag, "if", { | ||
| or_condition_node, null_const_node, wrap_slice_node }); | ||
|
|
||
| return if_ndoe; |
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
zhanglistar
reviewed
Dec 25, 2023
| end_is_null_node, | ||
| null_const_node, | ||
| step_is_null_node, | ||
| or_condition_node, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
(Fixes: #4029)
How was this patch tested?
manual tests
测试数据
测试elt函数，测试SQL
select count(1) from test_tbl where elt(1, d) >1, 表定义 test_tbl(d bigint) 数据量3000W， 测试3次PR改动前：8.936s， 9.921s， 9.661s
PR改动后：8.322s，7.845s，7.668s