[CH] Use if function if condition size is 1 #4042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/oap-project/gluten/issues Then could you also rename commit message and pull request title in the following format? See also: |
|
Run Gluten Clickhouse CI |
taiyang-li
reviewed
Dec 18, 2023
|
Run Gluten Clickhouse CI |
1 similar comment
|
Run Gluten Clickhouse CI |
zhanglistar
force-pushed
the
multiif-opt
branch
from
3dc3a9d
to
e702a89
Compare
|
Run Gluten Clickhouse CI |
1 similar comment
|
Run Gluten Clickhouse CI |
zhanglistar
force-pushed
the
multiif-opt
branch
from
3a3c9b8
to
3ad5a53
Compare
|
Run Gluten Clickhouse CI |
zhanglistar
force-pushed
the
multiif-opt
branch
from
3ad5a53
to
c53335a
Compare
|
Run Gluten Clickhouse CI |
zhanglistar
force-pushed
the
multiif-opt
branch
from
c53335a
to
14d738c
Compare
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
(Fixes: #4041)
If performance is better than mulitiIf, so we use if function if we have only on condition.
How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
CI
Function
ifhas better performance thanmulitiIfwhen there is only one condition, especially after PR:ClickHouse/ClickHouse#57885
On SQL 7954_0
Before:
After PR ClickHouse/ClickHouse#57745
Still if is faster than multiIf:
