-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GLUTEN-4160][CORE] Fix ClassCastException occurred when fallback broadcast join and broadcast exchange #4166
Conversation
Run Gluten Clickhouse CI |
Hi @zhouyuan , could you help me to review this pr ? |
Run Gluten Clickhouse CI |
Hi everyone, i fix the scalastyle check faild |
Hi, The centos7-test was due to low memory, how to retry it?
|
Run Gluten Clickhouse CI |
if (GlutenConfig.getConf.enableScanOnly) { | ||
// Disable ColumnarSubqueryBroadcast for scan-only execution. | ||
if ( | ||
GlutenConfig.getConf.enableScanOnly || !GlutenConfig.getConf.enableColumnarBroadcastExchange |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You disable columnar dpp if the columnar broadcast exchange is disabled. Why does this issue relate to when broadcastJoin is disabled
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because I used the following configuration for the test, i think the issue should be changed to when fallback broadcast join and broadcast exchange
--conf spark.gluten.sql.columnar.broadcastJoin=false
--conf spark.gluten.sql.columnar.broadcastExchange=false
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated the issue description, thanks.
…adcast join and broadcast exchange
Run Gluten Clickhouse CI |
Hi @ulysses-you , the ubuntu2004-test-spark32-slow environment test failed due to network reasons. Could you help to retry it or skip it, thanks. |
What changes were proposed in this pull request?
An exception occurred when I disabled broadcasthashjoin,I expect it to work fine after I fallback broadcasthashjoin and broadcastExchange. here's how to make it happen, run tpcds q31 with the following configuration
--conf spark.gluten.sql.columnar.broadcastJoin=false
--conf spark.gluten.sql.columnar.broadcastExchange=false
(Fixes: #4160)
How was this patch tested?
Run tpcds q31 with the following configurations
--conf spark.gluten.sql.columnar.broadcastJoin=false
--conf spark.gluten.sql.columnar.broadcastExchange=false