Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GLUTEN-4160][CORE] Fix ClassCastException occurred when fallback broadcast join and broadcast exchange #4166

Merged
merged 1 commit into from
Dec 27, 2023
Merged

[GLUTEN-4160][CORE] Fix ClassCastException occurred when fallback broadcast join and broadcast exchange #4166

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions gluten-core/src/main/scala/io/glutenproject/expression/ExpressionConverter.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -535,8 +535,11 @@ object ExpressionConverter extends SQLConfHelper with Logging {
ColumnarBroadcastExchangeExec(exchange.mode, newChild)
}

if (GlutenConfig.getConf.enableScanOnly) {
// Disable ColumnarSubqueryBroadcast for scan-only execution.
if (
GlutenConfig.getConf.enableScanOnly || !GlutenConfig.getConf.enableColumnarBroadcastExchange
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You disable columnar dpp if the columnar broadcast exchange is disabled. Why does this issue relate to when broadcastJoin is disabled ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because I used the following configuration for the test, i think the issue should be changed to when fallback broadcast join and broadcast exchange
--conf spark.gluten.sql.columnar.broadcastJoin=false
--conf spark.gluten.sql.columnar.broadcastExchange=false

Copy link
Contributor Author

@fyp711 fyp711 Dec 27, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the issue description, thanks.

) {
// Disable ColumnarSubqueryBroadcast for scan-only execution
// or ColumnarBroadcastExchange was disabled.
partitionFilters
} else {
val newPartitionFilters = partitionFilters.map {
Expand Down
Loading