Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GLUTEN-4416][VL][CI] Enable AQE for TPC-H test in some CI jobs #4417

Merged
merged 2 commits into from
Jan 17, 2024

Conversation

zwangsheng
Copy link
Contributor

What changes were proposed in this pull request?

Close #4416

Enable Spark AQE when running Gluten TPC-H IT

How was this patch tested?

Exist CI

Copy link

#4416

Copy link

Run Gluten Clickhouse CI

@zwangsheng
Copy link
Contributor Author

PTAL @PHILO-HE, BTW, is there any additional consideration in disabled AQE for TPC-H IT?

@PHILO-HE
Copy link
Contributor

PTAL @PHILO-HE, BTW, is there any additional consideration in disabled AQE for TPC-H IT?

Thanks for your fix! Not sure why we disabled it before. Maybe, we can only keep it disabled for static-build-centos7-test CI job to cover no-AQE test.

Copy link

Run Gluten Clickhouse CI

@PHILO-HE PHILO-HE changed the title [GLUTEN-4416][IT] Enable Spark AQE when running Gluten TPC-H IT [GLUTEN-4416][CI] Enable AQE for TPC-H test in some CI jobs Jan 16, 2024
Copy link
Contributor

@PHILO-HE PHILO-HE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@zhouyuan zhouyuan changed the title [GLUTEN-4416][CI] Enable AQE for TPC-H test in some CI jobs [GLUTEN-4416][VL][CI] Enable AQE for TPC-H test in some CI jobs Jan 17, 2024
@ulysses-you
Copy link
Contributor

the failed tests are irrelevant

@ulysses-you ulysses-you merged commit 518ad39 into apache:main Jan 17, 2024
20 of 21 checks passed
@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_4417_time.csv log/native_master_01_16_2024_4a385c35d_time.csv difference percentage
q1 34.08 36.30 2.225 106.53%
q2 24.86 24.81 -0.056 99.77%
q3 38.00 38.93 0.934 102.46%
q4 37.44 38.39 0.952 102.54%
q5 70.64 71.25 0.614 100.87%
q6 7.42 7.20 -0.219 97.04%
q7 83.21 85.24 2.036 102.45%
q8 86.15 85.77 -0.387 99.55%
q9 122.87 123.25 0.385 100.31%
q10 44.46 47.09 2.625 105.91%
q11 20.48 19.77 -0.712 96.52%
q12 29.82 29.96 0.139 100.47%
q13 46.81 47.43 0.627 101.34%
q14 18.53 17.75 -0.786 95.76%
q15 30.87 29.20 -1.675 94.58%
q16 14.37 14.63 0.264 101.83%
q17 100.23 102.94 2.707 102.70%
q18 148.65 148.41 -0.241 99.84%
q19 14.14 13.64 -0.505 96.43%
q20 29.48 27.24 -2.233 92.42%
q21 224.73 227.99 3.264 101.45%
q22 13.81 13.92 0.117 100.84%
total 1241.03 1251.10 10.072 100.81%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[IT] Enable Spark AQE when running Gluten TPC-H IT
4 participants