-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VL][CI] Fix fallback to columnar shuffle in celeborn test #4474
Conversation
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/oap-project/gluten/issues Then could you also rename commit message and pull request title in the following format?
See also: |
Run Gluten Clickhouse CI |
@kerwin-zk could you please help to take a look on this? it seems some wrong results found on tpcds Q51 thanks, -yuan |
Post the error message: Executing SQL query from resource path /tpcds-queries/q51.sql...
Error running query q51. Error: FATAL: java.lang.RuntimeException: Error while decoding: java.lang.ArithmeticException: Decimal precision 34 exceeds max precision 27 |
OK, I'll take a look. |
Run Gluten Clickhouse CI |
@kerwin-zk does it mean the celeborn shuffle code path is broken at present ? |
@ulysses-you Yes, code containing #4415 might have issues with some corner cases when using Celeborn. |
thank you for the confirming |
@PHILO-HE Thanks for investigating this issue. Let's merge this one first to ensure the CI operates correctly. I will look into the corner case issue. |
===== Performance report for TPCH SF2000 with Velox backend, for reference only ====
|
What changes were proposed in this pull request?
Celeborn is not correctly installed, which causes CI test actually falls back to columnar shuffle.
How was this patch tested?
CI verification.