[VL] Fix and use flattenVector #4783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/oap-project/gluten/issues Then could you also rename commit message and pull request title in the following format? See also: |
|
/Benchmark Velox |
|
===== Performance report for TPCH SF2000 with Velox backend, for reference only ====
|
|
/Benchmark Velox |
marin-ma
force-pushed
the
test-flatten-vector
branch
from
08ac6b0
to
3e0502f
Compare
zhouyuan
reviewed
Mar 7, 2024
| @@ -222,6 +222,7 @@ arrow::Status VeloxShuffleWriter::init() { | |||
|
|
|||
| ARROW_ASSIGN_OR_RAISE( | |||
| partitioner_, Partitioner::make(options_.partitioning, numPartitions_, options_.startPartitionId)); | |||
| DLOG(INFO) << "Create partitioning type: " << std::to_string(options_.partitioning); | |||
There was a problem hiding this comment.
this looks like a debug log?
There was a problem hiding this comment.
Yes. The DLOG ensures that it only get printed with debug mode. We probably need this log for debugging, because sometimes the shuffle operator can get omitted on Spark UI, such as a single partitioning after limit operator.
|
===== Performance report for TPCH SF2000 with Velox backend, for reference only ====
|
loneylee
pushed a commit
to loneylee/gluten
that referenced
this pull request
Mar 15, 2024
taiyang-li
pushed a commit
to bigo-sg/gluten
that referenced
this pull request
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch re-enables the flattern vector optimizations.
The flattenVector optimization firstly landed in #4415
but partially reverted in #4474 due to some bugs on Celeborn code path.
Celeborn integration tests should check the code path already