-
Notifications
You must be signed in to change notification settings - Fork 418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CORE] Improve rewrite spark plan rules framework #4645
Conversation
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/oap-project/gluten/issues Then could you also rename commit message and pull request title in the following format?
See also: |
9a11c46
to
6543e73
Compare
Run Gluten Clickhouse CI |
Run Gluten Clickhouse CI |
Run Gluten Clickhouse CI |
Run Gluten Clickhouse CI |
1 similar comment
Run Gluten Clickhouse CI |
Run Gluten Clickhouse CI |
Run Gluten Clickhouse CI |
Run Gluten Clickhouse CI |
1 similar comment
Run Gluten Clickhouse CI |
/Benchmark Velox |
Run Gluten Clickhouse CI |
===== Performance report for TPCH SF2000 with Velox backend, for reference only ====
|
/Benchmark Velox |
===== Performance report for TPCH SF2000 with Velox backend, for reference only ====
|
/Benchmark Velox |
===== Performance report for TPCH SF2000 with Velox backend, for reference only ====
|
cc @liujiayi771 thank you |
@ulysses-you Great design. LGTM. Thanks. |
Run Gluten Clickhouse CI |
===== Performance report for TPCH SF2000 with Velox backend, for reference only ====
|
What changes were proposed in this pull request?
This pr adds a framework
RewriteSparkPlanRulesManager
to help rewrite spark plan rules and tag transform hint. It moves AddTransformHintRule before rewrite rules.RewriteSparkPlanRulesManager
would rewrite plan and apply AddTransformHintRule for each opeartor. If the rewritten opeartor is still TRANSFORM_UNSUPPORTED, using original opeartor.This pr also removes applyForValidation in AddTransformHintRule, so that we do not need to apply rewrite rules twice.
How was this patch tested?
Pass CI