setup dev enviroment in mac os #819
Conversation
|
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/oap-project/gluten/issues Then could you also rename commit message and pull request title in the following format? See also: |
| # Build Dev Environment in Mac OSX | ||
|
|
||
| This document describes how to set up a development environment in Mac OSX (for Velox backend). The development includes | ||
| both coding and runtime environment. For coding part, we follow the command practice to load |
| docker build -t gluten_dev:latest . | ||
| ``` | ||
|
|
||
| 2. start a container. The following command start a container based on the image we |
There was a problem hiding this comment.
*** will start a container ***
| gluten project as a maven project in IntelliJ. For runtime part, as Gluten has not supported building and running | ||
| in Mac OSX, we leverage docker container here. | ||
|
|
||
| 1. build docker image |
There was a problem hiding this comment.
Small suggestion: please capitalize the initial letter, also for 2/3/4/5.
| docker build -t gluten_dev:latest . | ||
| ``` | ||
|
|
||
| 2. start a container. The following command start a container based on the image we |
There was a problem hiding this comment.
Small suggestion: it is better to split the titles and other content into different lines, also for 3/4/5.
| ENV PATH=/spark-3.2.2-bin-hadoop3.2/bin:$PATH | ||
|
|
||
|
|
||
| RUN ln -fs /usr/share/zoneinfo/America/Los_Angeles /etc/localtime |
There was a problem hiding this comment.
It's user-location-specific command. Can it be removed or replaced by other command to adapt to different users?
|
have you try to build on macOS directly without Docker? |
|
yes, tons of issues
…On Mon, Jan 9, 2023 at 18:19 yoha.zy ***@***.***> wrote:
have you try to build on macOS directly without Docker?
—
Reply to this email directly, view it on GitHub
<#819 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFFQ6FC53SPXXHLOVLQH5DWRTBJ5ANCNFSM6AAAAAATTKKOAI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Let's close this since it doesn't work |
What changes were proposed in this pull request?
This PR adds Dockerfile and docs about how to build dev environment in mac os
How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)