[Gluten-825]Enable compiling in macOS. #827
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add some no-error compile options.
Yohahaha
changed the title
|
@CodingCat you may try this PR |
Yohahaha
commented
Jan 10, 2023
| @@ -908,18 +907,6 @@ Java_io_glutenproject_memory_alloc_NativeMemoryAllocator_bytesAllocated(JNIEnv* | |||
| JNI_METHOD_END(-1L) | |||
| } | |||
|
|
|||
| JNIEXPORT void JNICALL Java_io_glutenproject_tpc_MallocUtils_mallocTrim(JNIEnv* env, jobject obj) { | |||
There was a problem hiding this comment.
After search all project about this interface, I can not find any usage.
There was a problem hiding this comment.
@zhztheplayer Can we remove the API?
|
can we set a CI/CD step to build on mac? just to ensure that what is committed in this PR will not be broken |
|
also as discussed in slack, build_velox.sh also need some non-tiny changes....(is the correctness of the script covered by the current CI/CD?) |
|
I tested this PR, it didn't work in my local, seems GTEST changes is the deal breaker |
|
After thinking about real usage, build and run in macOS without docker has less benefits, so i would close this pr. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Platform:
MacOS 12.3 (Intel)
Apple clang 13.1.6
Homebrew 3.6.17
This pr enabling compile Gluten in macOS without Docker, pr #819 do similar things with Docker.
Add some no-error compile options, and modify some code to get macOS compatibility.
#825
References:
CPU Affinity on macOS
GTest with CMake
-Wpessimizing-move
How was this patch tested?
manul test.
Contract me if any problem in your macOS.