-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!(c++): Refactor code structure to consolidate include and src into a single src directory #533
Conversation
Signed-off-by: acezen <qiaozi.zwb@alibaba-inc.com>
Signed-off-by: acezen <qiaozi.zwb@alibaba-inc.com>
Signed-off-by: acezen <qiaozi.zwb@alibaba-inc.com>
Signed-off-by: acezen <qiaozi.zwb@alibaba-inc.com>
Hi, @lixueclaire, I create this PR to consolidate all code into a single src directory and brings some
|
Hi, I think the APIs maybe a little confusing now. Originally, we have |
You mean we should split reader and writer to |
I'm talking about the file names under the api directory. |
… meta_writer Signed-off-by: acezen <qiaozi.zwb@alibaba-inc.com>
I have changed the naming under api, could you help reviewing again? |
Signed-off-by: acezen <qiaozi.zwb@alibaba-inc.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now. And it's essential to update our documentation accordingly.
Reason for this PR
Our current project structure separates header files and source files into include and src directories, respectively. This approach, while beneficial in some contexts, adds complexity and overhead for smaller projects, and not fits to protobuf generated code. To simplify the structure and enhance maintainability, we need to consolidate all code into a single src directory.
What changes are included in this PR?
Here are some notable changes:
src
directory.arrow
andhigh-level
related code.api
headers to let users to easily to include the function of c++ library.Are these changes tested?
Yes
Are there any user-facing changes?
BREAKING CHANGE:
graphar/arrow_chunk_reader.h
tographar/arrow/chunk_reader.h
graphar/arrow_chunk_writer.h
tographar/arrow/chunk_writer.h
copy
way writer function has been moved fromarrow_chunk_writer.h
tochunk_info_writer.h