Skip to content
This repository has been archived by the owner on Mar 3, 2023. It is now read-only.

Upgrade Pex to 1.1.11. #1052

Merged
merged 3 commits into from
Jul 13, 2016
Merged

Upgrade Pex to 1.1.11. #1052

merged 3 commits into from
Jul 13, 2016

Conversation

objmagic
Copy link
Contributor

@objmagic objmagic commented Jul 8, 2016

resolves #1051

In this PR, I will restart CI many times to see if the same error will happen again...

@objmagic objmagic self-assigned this Jul 8, 2016
@billonahill
Copy link
Contributor

Looks good, thanks for doing this. Would you also please verify this branch in twitter's internal CI.

@kramasamy
Copy link
Contributor

@objmagic - can you check with our internal version as @billonahill pointed out so that we can merge this?

@billonahill
Copy link
Contributor

👍

@kramasamy
Copy link
Contributor

@objmagic and @nlu90 - can this PR be merged if internal CIs work?

@objmagic
Copy link
Contributor Author

@kramasamy yes

@billonahill
Copy link
Contributor

One more think to check is to make sure the docker builds work. Once that's verified I think it's fine to merge.

@objmagic
Copy link
Contributor Author

objmagic commented Jul 13, 2016

@kramasamy @billonahill

Internal CI passed. I can also build and run on Docker following steps here.

I'll go ahead to merge it if everyone think it's fine.

@nlu90
Copy link
Member

nlu90 commented Jul 13, 2016

👍 for internal jenkins CI

@objmagic
Copy link
Contributor Author

@benley do you want to have a look at this PR?

@billonahill
Copy link
Contributor

👍

@benley
Copy link

benley commented Jul 13, 2016

I think you might be missing some updates to pex/bin/pex.py; here's what that diff looks like from my repo: https://github.com/benley/bazel_rules_pex/pull/6/files#diff-da6b827279fc47e8b1603fe3af0f4a0e

The changes are pretty minor, so maybe you deliberately didn't include them?

@benley
Copy link

benley commented Jul 13, 2016

Aside from that, 👍

@objmagic
Copy link
Contributor Author

objmagic commented Jul 13, 2016

@benley I applied your patch: 37f9d74 and I can build fine.

@objmagic
Copy link
Contributor Author

Travis CI, internal CI, Docker build all passed, again.

@objmagic objmagic merged commit e6a1d84 into apache:master Jul 13, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade pex
5 participants