Skip to content
This repository has been archived by the owner on Mar 3, 2023. It is now read-only.

Include only Topology proto in heron java api jar #2247

Merged
merged 1 commit into from
Aug 26, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions heron/api/src/java/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ licenses(["notice"])

package(default_visibility = ["//visibility:public"])

load("/tools/rules/heron_deps", "heron_java_proto_files")
load("/tools/rules/heron_deps", "heron_java_api_proto_files")
load("/tools/rules/jarjar_rules", "jarjar_binary")
load("/tools/rules/build_defs", "DOCLINT_HTML_AND_SYNTAX")
load("/tools/rules/javadoc", "java_doc")
Expand All @@ -15,7 +15,7 @@ java_doc(
)

api_deps_files = \
heron_java_proto_files() + [
heron_java_api_proto_files() + [
":classification",
"//heron/common/src/java:basics-java",
]
Expand Down
34 changes: 0 additions & 34 deletions heron/proto/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -177,40 +177,6 @@ java_library(
],
)

# This is for binaries that don't want protobuf
# dependency to be included in the generated jar
java_library(
name = "proto-java-nl",
srcs = [
"Empty.java",
],
deps = [
":proto_common_java",
":proto_execution_state_java",
":proto_stats_java",
":proto_topology_java",
":proto_scheduler_java",
":proto_packing_plan_java",
":proto_physical_plan_java",
":proto_metrics_java",
":proto_tmaster_java",
":proto_tuple_java",
":proto_stmgr_java",
":proto_ckptmgr_java",
":proto_networktests_java",
"//third_party/java:protobuf-java-neverlink",
],
)

java_binary(
name = "proto-bin-java",
srcs = ["Empty.java"],
create_executable = 0,
deps = [
":proto-java-nl",
],
)

pex_library(
name = "proto-py",
deps = [
Expand Down
6 changes: 6 additions & 0 deletions tools/rules/heron_deps.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -16,3 +16,9 @@ def heron_java_proto_files():
"//heron/proto:proto_stmgr_java",
"@com_google_protobuf_protobuf_java//jar",
]

def heron_java_api_proto_files():
return [
"//heron/proto:proto_topology_java",
"@com_google_protobuf_protobuf_java//jar",
]