This repository has been archived by the owner on Mar 3, 2023. It is now read-only.
Fix bug in dry-run argument for update command #2831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajorgensen
force-pushed
the
aj/dry-run-argument
branch
from
b48fa79
to
c35536d
Compare
Since list_extra_args is an array the `+=` operator deconstructs a string and add each character as an individual array element. This made it so when the update command it would not detect if it was in dry-run mode and always run the update command. By encapsulating the `--dry-run` string in an list it is properly added as an argument and runs with the expected behavior. This also fixes an issue with the way the `dry_run_format` argument was being updated in the extra args dictionary
ajorgensen
force-pushed
the
aj/dry-run-argument
branch
from
c35536d
to
efb05f4
Compare
|
+1 |
kramasamy
approved these changes
Apr 1, 2018
nicknezis
pushed a commit
that referenced
this pull request
Sep 14, 2020
Since list_extra_args is an array the `+=` operator deconstructs a string and add each character as an individual array element. This made it so when the update command it would not detect if it was in dry-run mode and always run the update command. By encapsulating the `--dry-run` string in an list it is properly added as an argument and runs with the expected behavior. This also fixes an issue with the way the `dry_run_format` argument was being updated in the extra args dictionary
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
list_extra_argsis an array, the+=operator deconstructs astring and add each character as an individual array element. This made
it so when the update command it would not detect if it was in dry-run
mode and always run the update command. By encapsulating the
--dry-runstring in an list it is properly added as an argument and runs with the
expected behavior.