Skip to content
This repository has been archived by the owner on Mar 3, 2023. It is now read-only.

Use latest scala rules to fix tests #2937

Closed
wants to merge 1 commit into from

Conversation

Code0x58
Copy link
Contributor

This is for bazelbuild/rules_scala#532 which is breaking the builds at the moment.

@Code0x58 Code0x58 force-pushed the update-scala-rules branch 3 times, most recently from 6305e8b to 65ac59a Compare June 24, 2018 18:38
@Code0x58
Copy link
Contributor Author

Code0x58 commented Jun 24, 2018

It seems like the scala rules have changed a bit since the last pinned commit. Hopefully the SSL cert issue will be fixed with a renewal very soon as I don't feel I have the time to look into this more at the moment vs. waiting for Lightbend to fix the critical issue.

@erenavsarogullari
Copy link
Member

Hi @Code0x58,

Firstly, thanks to having a look this.

It looks like no matching toolchains found from latest travis log:

(18:43:50) ERROR: While resolving toolchains for target //heron/api/src/scala:api-scala: no matching toolchains found for types @io_bazel_rules_scala//scala:toolchain_type
(18:43:51) ERROR: Analysis of target '//heron/api/src/scala:api-scala' failed; build aborted: no matching toolchains found for types @io_bazel_rules_scala//scala:toolchain_type

From bazel doc, we can try setting default toolchain if no concern.

# WORKSPACE
# register default scala toolchain
load("@io_bazel_rules_scala//scala:toolchains.bzl", "scala_register_toolchains")
scala_register_toolchains()

Ref: https://github.com/bazelbuild/rules_scala/blob/master/README.md

@Code0x58
Copy link
Contributor Author

Thanks! It looks like that does the trick, I'll have a quick check in tomorrow morning.

@kramasamy
Copy link
Contributor

@Code0x58 @erenavsarogullari - is this good to go?

@Code0x58
Copy link
Contributor Author

Code0x58 commented Jun 25, 2018

Yep, I think this was merged as a part of #2928 though but not showing up because of the FF merge

@Code0x58
Copy link
Contributor Author

Yep, this is in. The build failure on master is down to #2925 now

@Code0x58 Code0x58 closed this Jun 26, 2018
@Code0x58 Code0x58 deleted the update-scala-rules branch July 7, 2020 00:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants