This repository has been archived by the owner on Mar 3, 2023. It is now read-only.
Add a script to start docker container with development environment #3366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docker/scripts/docker-dev-env.sh
Outdated
| # Default platform is ubuntu18.04. Other available platforms | ||
| # include centos7 | ||
| TARGET_PLATFORM=${1:-"ubuntu18.04"} | ||
| SCRATCH_DIR="docker" |
There was a problem hiding this comment.
Do you think we should make SCRATCH_DIR configurable by accepting an argument as the script is executed?
There was a problem hiding this comment.
Make sense. Also "docker" is not ideal for the scratch dir. Updated and cleaned up in the new push.
joshfischer1108
approved these changes
Oct 18, 2019
nwangtw
force-pushed
the
nwang/add_docker_script_for_linux_dev_environment
branch
from
b8ec5ef
to
9dbab19
Compare
|
Still can't add @xiaoyao1991 so far. :( |
sreev
pushed a commit
to sreev/incubator-heron
that referenced
this pull request
Apr 9, 2020
…pache#3366) * Add a script to start docker container with development environment * update * update comments for starting a new shell * map ports 8888 and 8889
nicknezis
pushed a commit
that referenced
this pull request
Sep 14, 2020
…3366) * Add a script to start docker container with development environment * update * update comments for starting a new shell * map ports 8888 and 8889
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mac dev environment could be tricky to set up since it requires Xcode's toolchain, and it is not easy to troubleshoot. This docker script can be useful for compiling source code without any setup other than installing Docker.
To use the script to create a docker image and run it:
$ sh docker/scripts/dev-env.sh
Write down the Docker container id (you can also find it with this command: "docker ps -a"). Next time you can run "docker container exec -it CONTAINER_ID bash" to start a new shell in the same container.
In the container:
$ ./bazel_config.py
$ bazel build --config=ubuntu heron/...
This is just the first version. There are a lot of room to improve. Any feedback is welcome~