This repository has been archived by the owner on Mar 3, 2023. It is now read-only.
Generate unique filename to upload a topology package #601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
maosongfu
commented
May 8, 2016
•
maosongfu
commented
- Add a UploaderUtils, providing utils method to generate unique filename to upload a topology package
- Add unit tests for it
- Refactor IUploader implementation to use this utils method to generate consistent filename
added 2 commits
May 7, 2016 21:52
… package 1. Add a UploaderUtils, providing utils method to generate unique filename to upload a topology package 2. Add unit tests for it 3. Refactor IUploader implementation to use this utils method to generate consistent filename
maosongfu
changed the title
| public static String generateFilename( | ||
| String topologyName, | ||
| String role) { | ||
| return generateFilename(topologyName, role, "", -1); |
There was a problem hiding this comment.
let us version 0 (since version numbers are never negative)
There was a problem hiding this comment.
let us also use some value for tag as well.
|
👍 |
|
@ajorgensen Could u please check whether your S3Uploader can also make use of this utils method? |
| String tag, | ||
| int version) { | ||
| return String.format("%s-%s-%s-%d-%d", | ||
| topologyName, role, tag, version, new Random().nextLong()); |
There was a problem hiding this comment.
What if instead of random you use timestamp or some other temporal value? That way my would be easier to tell which artifact is the newest. Curios your thoughts on that.
|
@maosongfu I am away until Tuesday but I can take a look at it then. |
saileshmittal
pushed a commit
that referenced
this pull request
May 18, 2016
* Provide utils method to generate unique filename to upload a topology package 1. Add a UploaderUtils, providing utils method to generate unique filename to upload a topology package 2. Add unit tests for it 3. Refactor IUploader implementation to use this utils method to generate consistent filename
saileshmittal
pushed a commit
that referenced
this pull request
May 19, 2016
* Provide utils method to generate unique filename to upload a topology package 1. Add a UploaderUtils, providing utils method to generate unique filename to upload a topology package 2. Add unit tests for it 3. Refactor IUploader implementation to use this utils method to generate consistent filename
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.